Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hippy-vue,hippy-react): added setNativeProps on element-node #430

Merged

Conversation

zoomchan-cxj
Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj commented Dec 1, 2020

…-node

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline.
  • Squash the repeat code commits, short patches are welcome.

@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #430 (d91efad) into master (d47d49b) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   58.32%   58.61%   +0.28%     
==========================================
  Files          25       25              
  Lines        1651     1660       +9     
==========================================
+ Hits          963      973      +10     
+ Misses        688      687       -1     
Impacted Files Coverage Δ
packages/hippy-vue/src/renderer/element-node.js 79.61% <100.00%> (+3.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47d49b...d91efad. Read the comment docs.

@zoomchan-cxj zoomchan-cxj force-pushed the feature/addSetNativeProps branch from 79928ee to 40e934a Compare December 1, 2020 13:05
@zoomchan-cxj zoomchan-cxj changed the title feat(hippy-vue,hippy-react): added setNativeProps function on element… feat(hippy-vue,hippy-react): added setNativeProps on element-node Dec 1, 2020
@zoomchan-cxj zoomchan-cxj force-pushed the feature/addSetNativeProps branch from 40e934a to d91efad Compare December 2, 2020 05:51
@zoomchan-cxj zoomchan-cxj merged commit d1f7e21 into Tencent:master Dec 2, 2020
@zoomchan-cxj zoomchan-cxj deleted the feature/addSetNativeProps branch July 30, 2021 03:33
boxizen pushed a commit to boxizen/Hippy that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants