Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): support background animation #686

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

ozonelmy
Copy link
Contributor

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline.
  • Squash the repeat code commits, short patches are welcome.

@ozonelmy ozonelmy requested a review from lgyhero April 14, 2021 03:51
}
});
};
- (BOOL)getLayerContentForColor:(UIColor *)color completionBlock:(void (^)(UIImage *))contentBlock {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to check if 'contentBlock' is nil.

Copy link

@lgyhero lgyhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozonelmy ozonelmy merged commit eebe2aa into Tencent:master Apr 14, 2021
@ozonelmy ozonelmy deleted the feature/color_animation branch April 14, 2021 04:15
@zoomchan-cxj zoomchan-cxj linked an issue Apr 15, 2021 that may be closed by this pull request
zoomchan-cxj pushed a commit that referenced this pull request Apr 19, 2021
 feat(ios): support backgroundcolor property animation
boxizen pushed a commit to boxizen/Hippy that referenced this pull request Aug 16, 2021
 feat(ios): support backgroundcolor property animation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望增加颜色渐变动画
2 participants