Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add unicode_string_view and js_value_wrapper #782

Merged

Conversation

churchill-zhang
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline.
  • Squash the repeat code commits, short patches are welcome.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #782 (d586854) into master (8d75ed0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   60.05%   60.05%           
=======================================
  Files          26       26           
  Lines        1675     1675           
=======================================
  Hits         1006     1006           
  Misses        669      669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d75ed0...d586854. Read the comment docs.

Copy link
Collaborator

@ilikethese ilikethese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR;

@churchill-zhang churchill-zhang merged commit 4783390 into Tencent:master May 31, 2021
@churchill-zhang churchill-zhang deleted the feat/unicode_string_view branch May 31, 2021 02:09
boxizen pushed a commit to boxizen/Hippy that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants