Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hippy-react): add nativeNode attributes info for debugging #923

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

JHGOGOGO
Copy link
Contributor

@JHGOGOGO JHGOGOGO commented Aug 12, 2021

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #923 (974b9a5) into master (753f386) will not change coverage.
The diff coverage is n/a.

❗ Current head 974b9a5 differs from pull request most recent head e06d72f. Consider uploading reports for the commit e06d72f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   61.35%   61.35%           
=======================================
  Files          29       29           
  Lines        1876     1876           
=======================================
  Hits         1151     1151           
  Misses        725      725           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753f386...e06d72f. Read the comment docs.

Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoomchan-cxj zoomchan-cxj merged commit 58827d6 into Tencent:master Aug 13, 2021
zoomchan-cxj pushed a commit that referenced this pull request Aug 13, 2021
boxizen pushed a commit to boxizen/Hippy that referenced this pull request Aug 17, 2021
boxizen pushed a commit to boxizen/Hippy that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants