Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix nested text layout error #929

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

ozonelmy
Copy link
Contributor

we needs consider baseline offfset for nested view

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@ozonelmy ozonelmy force-pushed the bugfix/text_nest_view_draw branch from da6f365 to fff6c77 Compare August 15, 2021 08:06
@ozonelmy ozonelmy force-pushed the bugfix/text_nest_view_draw branch from fff6c77 to 4b24339 Compare October 8, 2021 07:22
@ozonelmy ozonelmy force-pushed the bugfix/text_nest_view_draw branch from 3f9b790 to 33c163c Compare November 3, 2021 07:24
@ozonelmy ozonelmy force-pushed the bugfix/text_nest_view_draw branch from 33c163c to 48b961b Compare November 3, 2021 08:17
@ozonelmy ozonelmy changed the title [WIP]fix(ios): fix nested text layout error fix(ios): fix nested text layout error Nov 29, 2021
Copy link

@lgyhero lgyhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozonelmy ozonelmy merged commit 3e6fd9b into Tencent:master Nov 29, 2021
@ozonelmy ozonelmy deleted the bugfix/text_nest_view_draw branch November 29, 2021 06:35
ozonelmy added a commit to ozonelmy/Hippy that referenced this pull request Nov 29, 2021
* fix(ios): update rich text layout

* fix(ios): update rich text layout

* fix(ios): use fabs to compare float values
ozonelmy added a commit that referenced this pull request Nov 29, 2021
* fix(ios): update rich text layout

* fix(ios): update rich text layout

* fix(ios): use fabs to compare float values
zoomchan-cxj pushed a commit that referenced this pull request Dec 6, 2021
* fix(ios): update rich text layout

* fix(ios): update rich text layout

* fix(ios): use fabs to compare float values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants