From e424fde5bff531ae8f7b34c8b9a961a81e4f507a Mon Sep 17 00:00:00 2001 From: zealotchen Date: Tue, 5 Sep 2023 21:53:04 +0800 Subject: [PATCH 1/6] feat(js): open js profiler --- driver/js/src/vm/v8/v8_vm.cc | 4 ++++ framework/android/build.gradle | 2 ++ framework/android/gradle.properties | 2 ++ 3 files changed, 8 insertions(+) diff --git a/driver/js/src/vm/v8/v8_vm.cc b/driver/js/src/vm/v8/v8_vm.cc index 8e43e7adb08..82f80a1056f 100644 --- a/driver/js/src/vm/v8/v8_vm.cc +++ b/driver/js/src/vm/v8/v8_vm.cc @@ -88,6 +88,10 @@ V8VM::V8VM(const std::shared_ptr& param) : VM(param) { #endif FOOTSTONE_DLOG(INFO) << "Initialize"; v8::V8::Initialize(); +#ifdef ENABLE_INSPECTOR + auto trace = reinterpret_cast(platform->GetTracingController()); + devtools::DevtoolsDataSource::OnGlobalTracingControlGenerate(trace); +#endif } } create_params_.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator(); diff --git a/framework/android/build.gradle b/framework/android/build.gradle index 14fd6c253f4..ca5b76ebf91 100644 --- a/framework/android/build.gradle +++ b/framework/android/build.gradle @@ -96,6 +96,7 @@ android { assert !(INCLUDE_ABI_ARMEABI.toBoolean() && ANDROID_ARM_NEON.toBoolean()) arguments ( "-DCMAKE_BUILD_TYPE=Release", + "-DENABLE_INSPECTOR=$ENABLE_INSPECTOR", "-DMODULES=${getAllModules().join(';')}", *mergeCppDefinitions() ) @@ -123,6 +124,7 @@ android { arguments ( "-DCMAKE_BUILD_TYPE=Debug", "-DMODULES=${getAllModules().join(';')}", + "-DENABLE_INSPECTOR=$ENABLE_INSPECTOR", *mergeCppDefinitions() ) diff --git a/framework/android/gradle.properties b/framework/android/gradle.properties index 0f1d472f854..33d1e7f93b5 100644 --- a/framework/android/gradle.properties +++ b/framework/android/gradle.properties @@ -116,3 +116,5 @@ PUBLISH_ARTIFACT_ID=release # Specifies maven publish group ID # PUBLISH_GROUP_ID=com.tencent.hippy + +ENABLE_INSPECTOR=true From 2cc33450e360853351cefbcee06dd1ea813c827f Mon Sep 17 00:00:00 2001 From: zealotchen Date: Tue, 5 Sep 2023 22:09:16 +0800 Subject: [PATCH 2/6] chore(js): open js profiler --- driver/js/src/vm/v8/v8_vm.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver/js/src/vm/v8/v8_vm.cc b/driver/js/src/vm/v8/v8_vm.cc index 82f80a1056f..57212d40372 100644 --- a/driver/js/src/vm/v8/v8_vm.cc +++ b/driver/js/src/vm/v8/v8_vm.cc @@ -89,8 +89,8 @@ V8VM::V8VM(const std::shared_ptr& param) : VM(param) { FOOTSTONE_DLOG(INFO) << "Initialize"; v8::V8::Initialize(); #ifdef ENABLE_INSPECTOR - auto trace = reinterpret_cast(platform->GetTracingController()); - devtools::DevtoolsDataSource::OnGlobalTracingControlGenerate(trace); + auto trace = reinterpret_cast(platform->GetTracingController()); + devtools::DevtoolsDataSource::OnGlobalTracingControlGenerate(trace); #endif } } From eb0bc4b0abe71fdcb46e022650bb39a6229bb0bb Mon Sep 17 00:00:00 2001 From: zealotchen Date: Tue, 5 Sep 2023 22:10:53 +0800 Subject: [PATCH 3/6] chore(js): open js profiler --- framework/android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/android/build.gradle b/framework/android/build.gradle index ca5b76ebf91..f08a00fa722 100644 --- a/framework/android/build.gradle +++ b/framework/android/build.gradle @@ -96,7 +96,7 @@ android { assert !(INCLUDE_ABI_ARMEABI.toBoolean() && ANDROID_ARM_NEON.toBoolean()) arguments ( "-DCMAKE_BUILD_TYPE=Release", - "-DENABLE_INSPECTOR=$ENABLE_INSPECTOR", + "-DENABLE_INSPECTOR=$ENABLE_INSPECTOR", "-DMODULES=${getAllModules().join(';')}", *mergeCppDefinitions() ) From f07132e62934e4a57038a67b35c76d1fd3e870f0 Mon Sep 17 00:00:00 2001 From: zealotchen Date: Tue, 5 Sep 2023 22:47:25 +0800 Subject: [PATCH 4/6] chore(js): open js profiler --- framework/android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/android/build.gradle b/framework/android/build.gradle index f08a00fa722..8ee3b623b45 100644 --- a/framework/android/build.gradle +++ b/framework/android/build.gradle @@ -96,8 +96,8 @@ android { assert !(INCLUDE_ABI_ARMEABI.toBoolean() && ANDROID_ARM_NEON.toBoolean()) arguments ( "-DCMAKE_BUILD_TYPE=Release", - "-DENABLE_INSPECTOR=$ENABLE_INSPECTOR", "-DMODULES=${getAllModules().join(';')}", + "-DENABLE_INSPECTOR=$ENABLE_INSPECTOR", *mergeCppDefinitions() ) From 4c0b15428ceef6d271c0194b82c555d7564a5bec Mon Sep 17 00:00:00 2001 From: zealotchen Date: Wed, 6 Sep 2023 14:11:39 +0800 Subject: [PATCH 5/6] chore(js): open js profiler --- framework/android/build.gradle | 1 - 1 file changed, 1 deletion(-) diff --git a/framework/android/build.gradle b/framework/android/build.gradle index 8ee3b623b45..2e9a643fd2a 100644 --- a/framework/android/build.gradle +++ b/framework/android/build.gradle @@ -97,7 +97,6 @@ android { arguments ( "-DCMAKE_BUILD_TYPE=Release", "-DMODULES=${getAllModules().join(';')}", - "-DENABLE_INSPECTOR=$ENABLE_INSPECTOR", *mergeCppDefinitions() ) From 11f08c801aa3681491753d391eb951057ea0568b Mon Sep 17 00:00:00 2001 From: zealotchen Date: Wed, 6 Sep 2023 14:17:26 +0800 Subject: [PATCH 6/6] chore(js): open js profiler --- framework/android/gradle.properties | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/android/gradle.properties b/framework/android/gradle.properties index 33d1e7f93b5..5182f9e96a5 100644 --- a/framework/android/gradle.properties +++ b/framework/android/gradle.properties @@ -117,4 +117,7 @@ PUBLISH_ARTIFACT_ID=release # PUBLISH_GROUP_ID=com.tencent.hippy +# +# Specifies DEVTOOL INSPECTOR OPEN OR NOT +# ENABLE_INSPECTOR=true