Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still no insitu parsing for non null-terminated strings? #2181

Open
n00bmind opened this issue Jul 27, 2023 · 1 comment
Open

Still no insitu parsing for non null-terminated strings? #2181

n00bmind opened this issue Jul 27, 2023 · 1 comment

Comments

@n00bmind
Copy link

Hi.
I've been trying to follow the conversation on adding a length limit to input streams to support parsing non null-terminated strings.
I see there are a few issues and even pull requests (most of them several years old) discussing the concept, and I see some support for it was finally added to master for the Parse() interface.
However.. nothing of the sort was ever done for ParseInSitu(), so the obvious question is why?

At my studio, we're mainly interested in doing insitu parsing for efficiency, so we really need support for this for cases where we cannot control the format of the input string. I could ofc modify the source code and put something together (the most straightforward solution would seem to be to do something like 58d72c7).

But the question remains.. why support this for read-only parsing but not in situ parsing? Is there anything I'm missing here?

@n00bmind n00bmind changed the title Still no insitu parsing with a for non null-terminated strings? Still no insitu parsing for non null-terminated strings? Jul 27, 2023
@n00bmind
Copy link
Author

Example of one of the conversations I found while looking for a solution to this.. #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant