Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateRangePicker] 弹窗显示的时间与当前所选时间不一致 #1192

Closed
cfool opened this issue Jul 20, 2022 · 7 comments · Fixed by #1194
Closed

[DateRangePicker] 弹窗显示的时间与当前所选时间不一致 #1192

cfool opened this issue Jul 20, 2022 · 7 comments · Fixed by #1194
Labels
🐞 bug Something isn't working to be published fixed, not be published

Comments

@cfool
Copy link
Contributor

cfool commented Jul 20, 2022

tdesign-vue 版本

0.44.0

重现链接

https://codesandbox.io/s/tdesign-vue-demo-forked-kho2rx?file=/src/demo.vue

重现步骤

image
1、先点击startTime，关闭弹窗
2、再点击endTime

原issue问题未完全解决。
#1116 (comment)

期望结果

No response

实际结果

No response

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response
@github-actions
Copy link
Contributor

👋 @cfool，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@honkinglin
Copy link
Collaborator

image

timepicker 的数据响应问题，我们排查下

@uyarn uyarn added the 🐞 bug Something isn't working label Jul 20, 2022
@uyarn
Copy link
Collaborator

uyarn commented Jul 20, 2022 •
edited
Loading

vue2这块的执行时机很奇怪 同样的逻辑 这种方式打开 二次打开

  1. offsetHeight取不到值
    image
    2.执行之后没有正常滚动
    image

@cfool
Copy link
Contributor Author

cfool commented Jul 20, 2022

image

这个属性传错了，正确的属性应该是isShowPanel。 因为这个传错了，导致TimePickerPanel感知不到visible的变化。

@honkinglin
Copy link
Collaborator

image

这个属性传错了，正确的属性应该是isShowPanel。 因为这个传错了，导致TimePickerPanel感知不到visible的变化。

确实是传错了，你要不要提个 pr 处理下？

@uyarn
Copy link
Collaborator

uyarn commented Jul 21, 2022

image

这个属性传错了，正确的属性应该是isShowPanel。 因为这个传错了，导致TimePickerPanel感知不到visible的变化。

看起来确实是 昨天一直在排查滚动的问题 没有注意到props这边这个watch的值是无效的>.<

@honkinglin honkinglin linked a pull request Jul 21, 2022 that will close this issue
fix: 修复时间选择器滚动错误 #1194
Merged
16 tasks
@uyarn uyarn added the to be published fixed, not be published label Jul 21, 2022
@uyarn uyarn reopened this Jul 21, 2022
@xiaosansiji
Copy link
Collaborator

fixed in 0.44.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 修复时间选择器滚动错误 Tencent/tdesign-vue
4 participants
@cfool @xiaosansiji @honkinglin @uyarn