hosts alerts number

[ltrilety]

API nodes call is not always returning number of alerts per node, only when some alert happens for the node. That leads to situation when UI says No Data. Which is correct from UI perspective because there really are no data. However as monitoring software we are aware how many alerts we got. So proper behaviour for API will be to report 0 alerts in the case when no alert comes at all.

Tendrl version:
tendrl-api-1.6.1-1.el7.centos.noarch

[r0h4n]

@GowthamShanmugam

As @shirshendu suggested, we need default (0) values for all alert counter objects

https://github.com/Tendrl/commons/blob/master/tendrl/commons/objects/cluster_node_alert_counters/__init__.py
https://github.com/Tendrl/commons/blob/master/tendrl/commons/objects/node_alert_counters/__init__.py
https://github.com/Tendrl/commons/blob/master/tendrl/commons/objects/cluster_alert_counters/__init__.py
https://github.com/Tendrl/node-agent/blob/master/tendrl/integrations/gluster/objects/volume_alert_counters/__init__.py

[GowthamShanmugam]

@r0h4n but already it default value is 0 only
https://github.com/Tendrl/commons/blob/master/tendrl/commons/objects/node_alert_counters/__init__.py#L7

[r0h4n]

@Tendrl/api @Tendrl/frontend Backend sets alert counter value to 0 as default. Could you guys check if tendrl/api or tendrl/ui correctly displays the default value (0) if no alerts found?

[shirshendu]

We have "warning_count": "0" in the API. @ltrilety Could you please provide more detail on the scenario in which this key is absent?

[gnehapk]

@r0h4n @shirshendu As per @mcarrano comment , UI displays 0, if warning_count is 0 in API response else No Data in case no data is available for alert.

[ltrilety]

My scenario is very simple, just import the cluster and go to the cluster details - Hosts page.

[r0h4n]

@GowthamShanmugam Please triage this, you have fixed this issue recently

[GowthamShanmugam]

@shirshendu only for cluster and volume only Api is returning alert, for nodes alert count api is not returning anything.

[GowthamShanmugam]

This issue is fixed, please verify and close this issue @ltrilety

[nthomas-redhat]

@ltrilety ,Closing the issue. If you find any discrepancies, please re-open the issue

[ltrilety]

Checked on:
tendrl-ui-1.6.1-3.el7rhgs.noarch

looks good