Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is "Launch Dashboard" link for hosts in Hosts page when cluster is not yet imported #610

Closed
mbukatov opened this issue Sep 15, 2017 · 3 comments
Assignees

Comments

@mbukatov
Copy link
Contributor

mbukatov commented Sep 15, 2017

Description

There is "Launch Dashboard" link for hosts in Hosts page when cluster is not yet imported, which is not expected behavior, as verified by @julienlim:

if no cluster is imported,, the grafana dashboard button should not be visible

Version

Latest snapshot build from master branch (if not fixed, it will be part of upcoming 1.5.2 version):

tendrl-ui-1.5.1-20170915T080405.521a085.noarch

Steps to Reproduce

  1. Prepare machines with GlusterFS cluster, including gluster volume (I used nightly builds and volume_usmqe_alpha_distrep_4x2.create.conf)
  2. Install Tendrl via tendrl-ansible there, using snapshot builds
  3. Log into the Tendrl web interface as an admin user
  4. Click on "Hosts" item in the menu to get to the Hosts page
  5. See hosts listed on the page

Actual Results

There are buttons linking to Grafana dashboard for all machines, even though the cluster hasn't been imported yet.

screenshot_20170915_104856

To provide a complete reference here, the linked dashboard looks like this:

screenshot_20170915_105052

Expected Results

There are no links to Grafana dashboard at this point. The links will be shown only later, when the cluster is imported.

@mbukatov
Copy link
Contributor Author

This issue has been discussed during Daily meeting of developers of Tendrl on 2017-09-18: api may need to provide additional information for ui to check if hosts is part of imported cluster, @r0h4n and @gnehapk know the details.

@gnehapk gnehapk mentioned this issue Sep 18, 2017
@gnehapk
Copy link
Member

gnehapk commented Sep 19, 2017

@mbukatov Its fixed in tendrl-ui-1.5.2-20170919T120332.90b043e.noarch.rpm. Please verify.

@mbukatov
Copy link
Contributor Author

mbukatov commented Sep 26, 2017

Verifying with tendrl-ui-1.5.2-20170925T180704.770936f.noarch and it works, Launch Dashboard buttons for hosts of not imported cluster are grey out and it's not possible to click on them

screenshot_20170926_092546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants