Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "NA" to "None" or 0 #658

Closed
julienlim opened this issue Oct 3, 2017 · 5 comments
Closed

Change "NA" to "None" or 0 #658

julienlim opened this issue Oct 3, 2017 · 5 comments
Assignees

Comments

@julienlim
Copy link
Member

julienlim commented Oct 3, 2017

For views where "NA" is used, NA is too vague. Please instead use the following:

Hosts List:

  • For NA (for Cluster), change to None (if no Cluster)

Hosts List, Volumes List:

  • For NA (for Alerts), change to 0 when there are no Alerts

screen shot 2017-10-03 at 1 56 09 pm

@gnehapk @a2batic @Tendrl/tendrl-qe @mcarrano

@mbukatov
Copy link
Contributor

mbukatov commented Oct 4, 2017

I suggest to use zero value only when the value from backend is really reported as zero, and NA when the value is not available (so that there is nothing to report).

@julienlim Would it be ok to use NA for cases when the value is not available at all? I would be ok with that.

Which means that in this case, we need to figure out where the problem actually is:

  • value is not reported by backed at all
  • ui doesn't ask for the value and then the ui reports the value as not available
  • ui receives the value, but represents it in a wrong way

In other words, this is not just a sheer change of the label, and we need to be sure that the backed works before trying to fix this.

@mcarrano
Copy link

mcarrano commented Oct 4, 2017

I think there are actually three conditions that should be differentiated.

  • A "0" value. Agree that in this case we should display 0 as in "0 alerts".
  • A null association, e.g. where a host has no associated cluster. In this case I think displaying "None" makes sense.
  • There is no data available. I asked around a bit with the UXD team on this one. While we have no definite standard, I recommend "No Data." It's more specific than "NA" but shorter than "Data Unavailable" or "Not Available"

cloudbehl added a commit that referenced this issue Oct 9, 2017
tendrl-bug-id's: #660, #659, #658, #654, #651, #656
@cloudbehl cloudbehl mentioned this issue Oct 9, 2017
cloudbehl added a commit that referenced this issue Oct 9, 2017
tendrl-bug-id's: #660, #659, #658, #654, #651, #656
cloudbehl added a commit that referenced this issue Oct 9, 2017
cloudbehl added a commit that referenced this issue Oct 10, 2017
cloudbehl added a commit that referenced this issue Oct 10, 2017
cloudbehl added a commit that referenced this issue Oct 10, 2017
cloudbehl added a commit that referenced this issue Oct 11, 2017
tendrl-bug-id's: #660, #659, #658,
@cloudbehl
Copy link
Member

@julienlim The Issue has been fixed, Please verify with the master build(tendrl-ui-1.5.2-20171011T095120.b554d56.src.rpm).

@julienlim
Copy link
Member Author

I've confirmed that when there are no alerts, it says No Data.
screen shot 2017-10-24 at 2 05 21 pm

Have still to verify when no cluster present.

@julienlim
Copy link
Member Author

Confirmed that Cluster column says "None" when node is not part of a Gluster cluster.
screen shot 2017-10-25 at 2 02 56 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants