fix(search): re-implementing mixinControlValueAccessor #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshSchoen
reviewed
May 12, 2022
...t/components/component-demos/search/demos/search-demo-input/search-demo-input.component.html
Show resolved
Hide resolved
|
🎉 This PR is included in version 4.1.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
re-implementing the search input to use mixinControlValueAccessor from our common package
closes #1932
What's included?
Test Steps
npm run startGeneral Tests for Every PR
npm run startstill works.npm run lintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.