Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-editor): commonjs dependencies #1941

Merged
merged 2 commits into from
May 18, 2022
Merged

fix(text-editor): commonjs dependencies #1941

merged 2 commits into from
May 18, 2022

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented May 17, 2022

Description

After using @covalent/text-editor it was discovered that EasyMDE library was not being correctly imported in a 12.x/13.x project.

closes #1940

What's included?

  • Moving away from module import over to a commonjs style include

NOTE: Consumers must now import EasyMDE within their projects. this will no longer be included directly in the component.

Test Steps

  • npm run start
  • then open localhost and view the text-editor example
  • finally verify the text-editor works exactly as beforre

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

@owilliams320 owilliams320 merged commit 33adc5f into main May 18, 2022
@owilliams320 owilliams320 deleted the develop branch May 18, 2022 19:19
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 4.1.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text-editor not working with angular 12
3 participants