Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): adding better dark mode support #2028

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Jun 9, 2023

Description

Adding better dark mode support to address #2023

What's included?

  • removed a bunch of classes that are calling a color directly and replaced with themed color
  • add secondary class to pull theme color

Test Steps

  • npm run start
  • then open the local browser
  • finally go over the site to ensure accuracy

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

closes #2023

Screenshots or link to StackBlitz/Plunker

covalent-dark-mode-fix

mikespudwebb
mikespudwebb previously approved these changes Jun 9, 2023
Copy link
Collaborator

@mikespudwebb mikespudwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome sauce!!

@owilliams320 owilliams320 merged commit ee18951 into main Jun 12, 2023
@owilliams320 owilliams320 deleted the fix/prefers-dark branch June 12, 2023 13:35
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 6.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Covalent Site Appearance Issue in Dark Mode
2 participants