Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): set default label text #2035

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

KhizerRehan
Copy link
Contributor

@KhizerRehan KhizerRehan commented Jul 5, 2023

Description

This PR adds default label text in for 'Neutral' action ribbon

Fixes #2034

Test Steps

  • npm run storybook
Screenshots or link to StackBlitz/Plunker
no-changes-default-text

@owilliams320
Copy link
Collaborator

Hello @KhizerRehan thanks for the PR! Can you use this text as the default label for neutral "No changes". Design for this is posted at https://teradata.github.io/design/

Screenshot 2023-07-10 at 12 15 02 PM

Copy link
Collaborator

@mikespudwebb mikespudwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

@owilliams320 owilliams320 merged commit bf594ae into Teradata:main Jul 18, 2023
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 6.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display undefined label for Neutral Action Ribbon
3 participants