Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External links should use the external link icons, by default #2063

Closed
fs250044 opened this issue Oct 26, 2023 · 1 comment · Fixed by #2070
Closed

External links should use the external link icons, by default #2063

fs250044 opened this issue Oct 26, 2023 · 1 comment · Fixed by #2070
Labels

Comments

@fs250044
Copy link

Is your feature request related to a problem? Please describe.
When viewing a MD text hyperlink, users have no way to know if the link will open an external browser window or not.

Describe the solution you'd like
The open in new icon should be added to links that open a new window (that is, that link to something outside of the current domain).

Describe alternatives you've considered
The image/icon could manually be added to every link, but that (1) becomes a maintenance nightmare and (2) makes it impossible to change out iconsets.

Additional context
Would be nice to be able to:

  1. Define the exact icon to use (e.g., https://fonts.google.com/icons?icon.query=open+in+new)
  2. Define the exact "home" domain.
  3. Be able to also add (or not) the icon on-demand.
@owilliams320
Copy link
Collaborator

🎉 This issue has been resolved in version 8.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants