Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper fix for #10 - better key/char handling for ComputerTerminalWidget #11

Open
Cervator opened this issue Oct 24, 2020 · 1 comment · May be fixed by #12
Open

Proper fix for #10 - better key/char handling for ComputerTerminalWidget #11

Cervator opened this issue Oct 24, 2020 · 1 comment · May be fixed by #12
Assignees
Labels
Type: Bug Issues reporting and PRs fixing problems

Comments

@Cervator
Copy link
Member

At present the ComputerTerminalWidget class has char character = 'x'; // event.getKeyCharacter(); where it seemingly used to be we could get both the id for a given key and the character it represents from NUIKeyEvent - but now only the id is available. Just commented it out in #10 so that the module would compile.

An alternative method onCharEvent is available in UIWidget but while it then provides the char it does not obviously capture the id and make it available 🤔

Probably the solution is to either provide both on one of those methods or make an easy way to look up one from the other. @DarkWeird has shown interest in fixing this at some point, but it is low priority anyway since ModularComputers doesn't work well at the moment.

@Cervator Cervator added the Type: Bug Issues reporting and PRs fixing problems label Oct 24, 2020
@Cervator
Copy link
Member Author

I suspect about the same issue may be true for https://github.com/Terasology/KComputers/blob/develop/src/main/java/org/terasology/kcomputers/rendering/nui/layers/ComputerDisplayWidget.java#L68 (haven't compile fixed, but doesn't work in normal cases anyway)

@DarkWeird DarkWeird linked a pull request Oct 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants