From 5764a79614e0551ce71f6d4344c59899365d7cf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Breu=C3=9F?= Date: Sun, 17 Mar 2024 14:28:26 +0100 Subject: [PATCH 1/3] Remove obsolete factory methods --- .../MockDirectoryInfoFactory.cs | 8 --- .../MockDriveInfoFactory.cs | 7 -- .../MockFileInfoFactory.cs | 7 -- .../MockFileStreamFactory.cs | 65 ------------------- .../MockFileSystemWatcherFactory.cs | 15 ----- .../DirectoryInfoFactory.cs | 7 -- .../DriveInfoFactory.cs | 10 --- .../FileInfoFactory.cs | 6 -- .../FileStreamFactory.cs | 60 ----------------- .../FileSystemWatcherFactory.cs | 15 ----- .../IDirectoryInfoFactory.cs | 7 -- .../IDriveInfoFactory.cs | 7 -- .../IFileInfoFactory.cs | 7 -- .../IFileStreamFactory.cs | 52 --------------- .../IFileSystemWatcherFactory.cs | 24 ------- 15 files changed, 297 deletions(-) diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectoryInfoFactory.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectoryInfoFactory.cs index 7067a231d..f73697b43 100644 --- a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectoryInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectoryInfoFactory.cs @@ -18,14 +18,6 @@ public MockDirectoryInfoFactory(IMockFileDataAccessor mockFileSystem) public IFileSystem FileSystem => mockFileSystem; - - /// - [Obsolete("Use `IDirectoryInfoFactory.New(string)` instead")] - public IDirectoryInfo FromDirectoryName(string directoryName) - { - return New(directoryName); - } - /// public IDirectoryInfo New(string path) { diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDriveInfoFactory.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDriveInfoFactory.cs index 9fafc539d..11aa610ff 100644 --- a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDriveInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDriveInfoFactory.cs @@ -59,13 +59,6 @@ public IDriveInfo Wrap(DriveInfo driveInfo) return New(driveInfo.Name); } - /// - [Obsolete("Use `IDirectoryInfoFactory.New(string)` instead")] - public IDriveInfo FromDriveName(string driveName) - { - return New(driveName); - } - private string NormalizeDriveName(string driveName) { if (driveName.Length == 3 && mockFileSystem.StringOperations.EndsWith(driveName, @":\")) diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileInfoFactory.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileInfoFactory.cs index 7c75e9014..44c28061b 100644 --- a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileInfoFactory.cs @@ -18,13 +18,6 @@ public MockFileInfoFactory(IMockFileDataAccessor mockFileSystem) public IFileSystem FileSystem => mockFileSystem; - /// - [Obsolete("Use `IFileInfoFactory.New(string)` instead")] - public IFileInfo FromFileName(string fileName) - { - return New(fileName); - } - /// public IFileInfo New(string fileName) { diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStreamFactory.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStreamFactory.cs index 5a1c4bde5..26a773f0a 100644 --- a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStreamFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStreamFactory.cs @@ -19,71 +19,6 @@ public MockFileStreamFactory(IMockFileDataAccessor mockFileSystem) public IFileSystem FileSystem => mockFileSystem; - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode)` instead.")] - public Stream Create(string path, FileMode mode) - => New(path, mode); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access) - => New(path, mode, access); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share) - => New(path, mode, access, share); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize) - => New(path, mode, access, share, bufferSize); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int, FileOptions)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize, FileOptions options) - => New(path, mode, access, share, bufferSize, options); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int, bool)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize, bool useAsync) - => New(path, mode, access, share, bufferSize, useAsync); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access) instead. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access) - => new MockFileStream(mockFileSystem, handle.ToString(), FileMode.Open, access: access); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access, bool ownsHandle) - => new MockFileStream(mockFileSystem, handle.ToString(), FileMode.Open, access: access); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access, int bufferSize) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access, bool ownsHandle, int bufferSize) - => new MockFileStream(mockFileSystem, handle.ToString(), FileMode.Open, access: access); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access, int bufferSize, bool isAsync) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access, bool ownsHandle, int bufferSize, bool isAsync) - => new MockFileStream(mockFileSystem, handle.ToString(), FileMode.Open, access: access); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess)` instead.")] - public Stream Create(SafeFileHandle handle, FileAccess access) - => New(handle, access); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess, int)` instead.")] - public Stream Create(SafeFileHandle handle, FileAccess access, int bufferSize) - => New(handle, access, bufferSize); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess, int, bool)` instead.")] - public Stream Create(SafeFileHandle handle, FileAccess access, int bufferSize, bool isAsync) - => New(handle, access, bufferSize, isAsync); - /// public FileSystemStream New(SafeFileHandle handle, FileAccess access) => new MockFileStream(mockFileSystem, handle.ToString(), FileMode.Open, access: access); diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystemWatcherFactory.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystemWatcherFactory.cs index 3e851080b..a55f3ef5e 100644 --- a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystemWatcherFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystemWatcherFactory.cs @@ -16,21 +16,6 @@ public MockFileSystemWatcherFactory(MockFileSystem mockFileSystem) /// public IFileSystem FileSystem { get; } - /// - [Obsolete("Use `IFileSystemWatcherFactory.New()` instead")] - public IFileSystemWatcher CreateNew() - => New(); - - /// - [Obsolete("Use `IFileSystemWatcherFactory.New(string)` instead")] - public IFileSystemWatcher CreateNew(string path) - => New(path); - - /// - [Obsolete("Use `IFileSystemWatcherFactory.New(string, string)` instead")] - public IFileSystemWatcher CreateNew(string path, string filter) - => New(path, filter); - /// public IFileSystemWatcher New() => throw new NotImplementedException(StringResources.Manager.GetString("FILE_SYSTEM_WATCHER_NOT_IMPLEMENTED_EXCEPTION")); diff --git a/src/TestableIO.System.IO.Abstractions.Wrappers/DirectoryInfoFactory.cs b/src/TestableIO.System.IO.Abstractions.Wrappers/DirectoryInfoFactory.cs index 8994614ce..326d8faf2 100644 --- a/src/TestableIO.System.IO.Abstractions.Wrappers/DirectoryInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.Wrappers/DirectoryInfoFactory.cs @@ -17,13 +17,6 @@ public DirectoryInfoFactory(IFileSystem fileSystem) public IFileSystem FileSystem => fileSystem; - /// - [Obsolete("Use `IDirectoryInfoFactory.New(string)` instead")] - public IDirectoryInfo FromDirectoryName(string directoryName) - { - return New(directoryName); - } - /// public IDirectoryInfo New(string path) { diff --git a/src/TestableIO.System.IO.Abstractions.Wrappers/DriveInfoFactory.cs b/src/TestableIO.System.IO.Abstractions.Wrappers/DriveInfoFactory.cs index 5a340eb05..edbc9cf72 100644 --- a/src/TestableIO.System.IO.Abstractions.Wrappers/DriveInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.Wrappers/DriveInfoFactory.cs @@ -47,15 +47,5 @@ public IDriveInfo Wrap(DriveInfo driveInfo) return new DriveInfoWrapper(fileSystem, driveInfo); } - - /// - /// Initializes a new instance of the class, which acts as a wrapper for a logical drive. - /// - /// A valid drive path or drive letter. - [Obsolete("Use `IDriveInfoFactory.New(string)` instead")] - public IDriveInfo FromDriveName(string driveName) - { - return New(driveName); - } } } diff --git a/src/TestableIO.System.IO.Abstractions.Wrappers/FileInfoFactory.cs b/src/TestableIO.System.IO.Abstractions.Wrappers/FileInfoFactory.cs index 411c06db7..afa3b5c62 100644 --- a/src/TestableIO.System.IO.Abstractions.Wrappers/FileInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.Wrappers/FileInfoFactory.cs @@ -17,12 +17,6 @@ public FileInfoFactory(IFileSystem fileSystem) public IFileSystem FileSystem => fileSystem; - /// - [Obsolete("Use `IFileInfoFactory.New(string)` instead")] - public IFileInfo FromFileName(string fileName) - { - return New(fileName); - } /// public IFileInfo New(string fileName) diff --git a/src/TestableIO.System.IO.Abstractions.Wrappers/FileStreamFactory.cs b/src/TestableIO.System.IO.Abstractions.Wrappers/FileStreamFactory.cs index 46c4deb31..309ca8e2e 100644 --- a/src/TestableIO.System.IO.Abstractions.Wrappers/FileStreamFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.Wrappers/FileStreamFactory.cs @@ -15,66 +15,6 @@ public FileStreamFactory(IFileSystem fileSystem) /// public IFileSystem FileSystem { get; } - [Obsolete("Use `IFileStreamFactory.New(string, FileMode)` instead.")] - public Stream Create(string path, FileMode mode) - => New(path, mode); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access) - => New(path, mode, access); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share) - => New(path, mode, access, share); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize) - => New(path, mode, access, share, bufferSize); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int, FileOptions)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize, FileOptions options) - => New(path, mode, access, share, bufferSize, options); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int, bool)` instead.")] - public Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize, bool useAsync) - => New(path, mode, access, share, bufferSize, useAsync); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess)` instead.")] - public Stream Create(SafeFileHandle handle, FileAccess access) - => New(handle, access); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess, int)` instead.")] - public Stream Create(SafeFileHandle handle, FileAccess access, int bufferSize) - => New(handle, access, bufferSize); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess, int, bool)` instead.")] - public Stream Create(SafeFileHandle handle, FileAccess access, int bufferSize, bool isAsync) - => New(handle, access, bufferSize, isAsync); - - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access) instead. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access) - => new FileStream(handle, access); - - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access, bool ownsHandle) - => new FileStream(handle, access, ownsHandle); - - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access, int bufferSize) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access, bool ownsHandle, int bufferSize) - => new FileStream(handle, access, ownsHandle, bufferSize); - - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access, int bufferSize, bool isAsync) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - public Stream Create(IntPtr handle, FileAccess access, bool ownsHandle, int bufferSize, bool isAsync) - => new FileStream(handle, access, ownsHandle, bufferSize, isAsync); - /// public FileSystemStream New(SafeFileHandle handle, FileAccess access) => new FileStreamWrapper(new FileStream(handle, access)); diff --git a/src/TestableIO.System.IO.Abstractions.Wrappers/FileSystemWatcherFactory.cs b/src/TestableIO.System.IO.Abstractions.Wrappers/FileSystemWatcherFactory.cs index 04057943d..e12c9e1ac 100644 --- a/src/TestableIO.System.IO.Abstractions.Wrappers/FileSystemWatcherFactory.cs +++ b/src/TestableIO.System.IO.Abstractions.Wrappers/FileSystemWatcherFactory.cs @@ -15,21 +15,6 @@ public FileSystemWatcherFactory(IFileSystem fileSystem) /// public IFileSystem FileSystem { get; } - /// - [Obsolete("Use `IFileSystemWatcherFactory.New()` instead")] - public IFileSystemWatcher CreateNew() - => New(); - - /// - [Obsolete("Use `IFileSystemWatcherFactory.New(string)` instead")] - public IFileSystemWatcher CreateNew(string path) - => New(path); - - /// - [Obsolete("Use `IFileSystemWatcherFactory.New(string, string)` instead")] - public IFileSystemWatcher CreateNew(string path, string filter) - => New(path, filter); - /// public IFileSystemWatcher New() => new FileSystemWatcherWrapper(FileSystem); diff --git a/src/TestableIO.System.IO.Abstractions/IDirectoryInfoFactory.cs b/src/TestableIO.System.IO.Abstractions/IDirectoryInfoFactory.cs index 63d97d7da..988bf53d0 100644 --- a/src/TestableIO.System.IO.Abstractions/IDirectoryInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions/IDirectoryInfoFactory.cs @@ -7,13 +7,6 @@ namespace System.IO.Abstractions /// public interface IDirectoryInfoFactory : IFileSystemEntity { - /// - /// Initializes a new instance of a wrapper for which implements . - /// - /// The fully qualified name of the new directory, or the relative directory name. - [Obsolete("Use `IDirectoryInfoFactory.New(string)` instead")] - IDirectoryInfo FromDirectoryName(string directoryName); - /// /// Initializes a new instance of a wrapper for which implements . /// diff --git a/src/TestableIO.System.IO.Abstractions/IDriveInfoFactory.cs b/src/TestableIO.System.IO.Abstractions/IDriveInfoFactory.cs index 997019486..080a9f57e 100644 --- a/src/TestableIO.System.IO.Abstractions/IDriveInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions/IDriveInfoFactory.cs @@ -7,13 +7,6 @@ namespace System.IO.Abstractions /// public interface IDriveInfoFactory : IFileSystemEntity { - /// - /// Initializes a new instance of a wrapper for which implements . - /// - /// A valid drive path or drive letter. - [Obsolete("Use `IDriveInfoFactory.New(string)` instead")] - IDriveInfo FromDriveName(string driveName); - /// /// Retrieves the drive names of all logical drives on a computer. /// diff --git a/src/TestableIO.System.IO.Abstractions/IFileInfoFactory.cs b/src/TestableIO.System.IO.Abstractions/IFileInfoFactory.cs index 20378dd8b..380d4373c 100644 --- a/src/TestableIO.System.IO.Abstractions/IFileInfoFactory.cs +++ b/src/TestableIO.System.IO.Abstractions/IFileInfoFactory.cs @@ -7,13 +7,6 @@ namespace System.IO.Abstractions /// public interface IFileInfoFactory : IFileSystemEntity { - /// - /// Initializes a new instance of a wrapper for which implements . - /// - /// The fully qualified name of the new file, or the relative file name. - [Obsolete("Use `IFileInfoFactory.New(string)` instead")] - IFileInfo FromFileName(string fileName); - /// /// Initializes a new instance of a wrapper for which implements . /// diff --git a/src/TestableIO.System.IO.Abstractions/IFileStreamFactory.cs b/src/TestableIO.System.IO.Abstractions/IFileStreamFactory.cs index 5cc605b11..ea33d6cac 100644 --- a/src/TestableIO.System.IO.Abstractions/IFileStreamFactory.cs +++ b/src/TestableIO.System.IO.Abstractions/IFileStreamFactory.cs @@ -7,58 +7,6 @@ namespace System.IO.Abstractions /// public interface IFileStreamFactory : IFileSystemEntity { - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode)` instead.")] - Stream Create(string path, FileMode mode); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess)` instead.")] - Stream Create(string path, FileMode mode, FileAccess access); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare)` instead.")] - Stream Create(string path, FileMode mode, FileAccess access, FileShare share); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int)` instead.")] - Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int, FileOptions)` instead.")] - Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize, FileOptions options); - - /// - [Obsolete("Use `IFileStreamFactory.New(string, FileMode, FileAccess, FileShare, int, bool)` instead.")] - Stream Create(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize, bool useAsync); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess)` instead.")] - Stream Create(SafeFileHandle handle, FileAccess access); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess, int)` instead.")] - Stream Create(SafeFileHandle handle, FileAccess access, int bufferSize); - - /// - [Obsolete("Use `IFileStreamFactory.New(SafeFileHandle, FileAccess, int, bool)` instead.")] - Stream Create(SafeFileHandle handle, FileAccess access, int bufferSize, bool isAsync); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access) instead. http://go.microsoft.com/fwlink/?linkid=14202")] - Stream Create(IntPtr handle, FileAccess access); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - Stream Create(IntPtr handle, FileAccess access, bool ownsHandle); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access, int bufferSize) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - Stream Create(IntPtr handle, FileAccess access, bool ownsHandle, int bufferSize); - - /// - [Obsolete("This method has been deprecated. Please use new Create(SafeFileHandle handle, FileAccess access, int bufferSize, bool isAsync) instead, and optionally make a new SafeFileHandle with ownsHandle=false if needed. http://go.microsoft.com/fwlink/?linkid=14202")] - Stream Create(IntPtr handle, FileAccess access, bool ownsHandle, int bufferSize, bool isAsync); - /// FileSystemStream New(SafeFileHandle handle, FileAccess access); diff --git a/src/TestableIO.System.IO.Abstractions/IFileSystemWatcherFactory.cs b/src/TestableIO.System.IO.Abstractions/IFileSystemWatcherFactory.cs index ab60e4f8e..bcb3fae0b 100644 --- a/src/TestableIO.System.IO.Abstractions/IFileSystemWatcherFactory.cs +++ b/src/TestableIO.System.IO.Abstractions/IFileSystemWatcherFactory.cs @@ -7,30 +7,6 @@ namespace System.IO.Abstractions /// public interface IFileSystemWatcherFactory : IFileSystemEntity { - /// - /// Initializes a new instance of a wrapper for which implements . - /// - /// - [Obsolete("Use `IFileSystemWatcherFactory.New()` instead")] - IFileSystemWatcher CreateNew(); - - /// - /// Initializes a new instance of a wrapper for which implements . - /// - /// The directory to monitor, in standard or Universal Naming Convention (UNC) notation. - /// - [Obsolete("Use `IFileSystemWatcherFactory.New(string)` instead")] - IFileSystemWatcher CreateNew(string path); - - /// - /// Initializes a new instance of a wrapper for which implements . - /// - /// The directory to monitor, in standard or Universal Naming Convention (UNC) notation. - /// The type of files to watch. For example, "*.txt" watches for changes to all text files. - /// - [Obsolete("Use `IFileSystemWatcherFactory.New(string, string)` instead")] - IFileSystemWatcher CreateNew(string path, string filter); - /// /// Initializes a new instance of a wrapper for which implements . /// From 6e015d870bb0dbac644e78a1c077a944644d0c43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Breu=C3=9F?= Date: Sun, 17 Mar 2024 14:28:33 +0100 Subject: [PATCH 2/3] Increment major version --- System.IO.Abstractions.sln | 1 + version.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/System.IO.Abstractions.sln b/System.IO.Abstractions.sln index 61974e370..dc7db9b01 100644 --- a/System.IO.Abstractions.sln +++ b/System.IO.Abstractions.sln @@ -27,6 +27,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "_", "_", "{BBF7AD8D-5522-48 Directory.Build.props = Directory.Build.props global.json = global.json README.md = README.md + version.json = version.json EndProjectSection EndProject Global diff --git a/version.json b/version.json index 1d4c04d8f..faa1bcb8f 100644 --- a/version.json +++ b/version.json @@ -1,6 +1,6 @@ { "$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json", - "version": "20.0", + "version": "21.0", "assemblyVersion": { "precision": "major" }, From 49dac583c23f3692d89292ad978f556c11874a1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Breu=C3=9F?= Date: Sun, 17 Mar 2024 14:36:16 +0100 Subject: [PATCH 3/3] Fixbuild errors --- .../MockFileStreamFactoryTests.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamFactoryTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamFactoryTests.cs index d339fa906..91e79ca49 100644 --- a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamFactoryTests.cs +++ b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamFactoryTests.cs @@ -23,7 +23,7 @@ public void MockFileStreamFactory_CreateForExistingFile_ShouldReturnStream(FileM var fileStreamFactory = new MockFileStreamFactory(fileSystem); // Act - var result = fileStreamFactory.Create(@"c:\existing.txt", fileMode, FileAccess.Write); + var result = fileStreamFactory.New(@"c:\existing.txt", fileMode, FileAccess.Write); // Assert Assert.That(result, Is.Not.Null); @@ -39,7 +39,7 @@ public void MockFileStreamFactory_CreateForNonExistingFile_ShouldReturnStream(Fi var fileStreamFactory = new MockFileStreamFactory(fileSystem); // Act - var result = fileStreamFactory.Create(XFS.Path(@"c:\not_existing.txt"), fileMode, FileAccess.Write); + var result = fileStreamFactory.New(XFS.Path(@"c:\not_existing.txt"), fileMode, FileAccess.Write); // Assert Assert.That(result, Is.Not.Null); @@ -82,7 +82,7 @@ public void MockFileStreamFactory_CreateInNonExistingDirectory_ShouldThrowDirect var fileStreamFactory = new MockFileStreamFactory(fileSystem); // Assert - Assert.Throws(() => fileStreamFactory.Create(XFS.Path(@"C:\Test\NonExistingDirectory\some_random_file.txt"), fileMode)); + Assert.Throws(() => fileStreamFactory.New(XFS.Path(@"C:\Test\NonExistingDirectory\some_random_file.txt"), fileMode)); } [Test] @@ -125,7 +125,7 @@ public void MockFileStreamFactory_OpenNonExistingFile_ShouldThrowFileNotFoundExc var fileStreamFactory = new MockFileStreamFactory(fileSystem); // Assert - Assert.Throws(() => fileStreamFactory.Create(XFS.Path(@"C:\Test\some_random_file.txt"), fileMode)); + Assert.Throws(() => fileStreamFactory.New(XFS.Path(@"C:\Test\some_random_file.txt"), fileMode)); } [Test] @@ -141,7 +141,7 @@ public void MockFileStreamFactory_CreateExistingFile_Should_Throw_IOException(Fi var fileStreamFactory = new MockFileStreamFactory(fileSystem); // Assert - Assert.Throws(() => fileStreamFactory.Create(path, fileMode)); + Assert.Throws(() => fileStreamFactory.New(path, fileMode)); } @@ -156,7 +156,7 @@ public void MockFileStreamFactory_CreateWithRelativePath_CreatesFileInCurrentDir // Act var fileStreamFactory = new MockFileStreamFactory(fileSystem); - fileStreamFactory.Create("some_random_file.txt", fileMode); + fileStreamFactory.New("some_random_file.txt", fileMode); // Assert Assert.That(fileSystem.File.Exists(XFS.Path("./some_random_file.txt")), Is.True);