Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move type registry into component state #64

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

himself65
Copy link
Contributor

Fixes: #62

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit b6a4033
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/632cac659dd8740008794c8a
😎 Deploy Preview https://deploy-preview-64--any-viewer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 87.52% // Head: 87.86% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (b6a4033) compared to base (8c626cf).
Patch coverage: 93.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   87.52%   87.86%   +0.34%     
==========================================
  Files          18       18              
  Lines        1683     1739      +56     
  Branches      212      220       +8     
==========================================
+ Hits         1473     1528      +55     
- Misses        210      211       +1     
Impacted Files Coverage Δ
src/stores/typeRegistry.tsx 93.83% <93.07%> (+0.37%) ⬆️
src/index.tsx 92.30% <100.00%> (+0.41%) ⬆️
src/type.ts 100.00% <0.00%> (ø)
src/stores/JsonViewerStore.ts 89.71% <0.00%> (+0.19%) ⬆️
src/components/DataTypes/createEasyType.tsx 64.55% <0.00%> (+0.45%) ⬆️
src/components/DataKeyPair.tsx 79.10% <0.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad cache Component data type behaviour
1 participant