Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Function component #81

Merged
merged 13 commits into from
Sep 23, 2022
Merged

Enhance Function component #81

merged 13 commits into from
Sep 23, 2022

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Sep 23, 2022

  • Added ability to work with short closures
  • Added pointer cursor
  • Added tests
  • Added showcases

@netlify
Copy link

netlify bot commented Sep 23, 2022

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit 0c6e0d4
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/632dbd77e5a3d100089bb4b8
😎 Deploy Preview https://deploy-preview-81--any-viewer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 89.69% // Head: 89.86% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (0c6e0d4) compared to base (46e1c68).
Patch coverage: 97.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   89.69%   89.86%   +0.17%     
==========================================
  Files          18       18              
  Lines        1785     1806      +21     
  Branches      246      255       +9     
==========================================
+ Hits         1601     1623      +22     
+ Misses        184      183       -1     
Impacted Files Coverage Δ
src/components/DataKeyPair.tsx 77.28% <50.00%> (ø)
src/components/DataTypes/Function.tsx 100.00% <100.00%> (+1.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65
Copy link
Contributor

Fixes: #72

@himself65 himself65 linked an issue Sep 23, 2022 that may be closed by this pull request
@himself65
Copy link
Contributor

Screenshot from 2022-09-23 08-29-27

still have the error

# Conflicts:
#	tests/index.test.tsx
@himself65
Copy link
Contributor

There still have Hydration errors. let me check later

@himself65
Copy link
Contributor

himself65 commented Sep 23, 2022

There still have Hydration errors. let me check later

I think that's because the server-side treat every function as the same(whether arrow function). but the client side is not.

Maybe we should turn NoSsr here?

https://mui.com/material-ui/react-no-ssr/

@xepozz
Copy link
Contributor Author

xepozz commented Sep 23, 2022

Yeap code is obfuscating by SSR and it should be disabled.
But the bug the function name doesn't match with it. I've fixed it.

@xepozz
Copy link
Contributor Author

xepozz commented Sep 23, 2022

It's completely ready for review and merge.

@himself65 himself65 merged commit d2e75d6 into TexteaInc:main Sep 23, 2022
@xepozz xepozz deleted the function branch September 23, 2022 14:35
Yazawazi pushed a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function inspect incorrect
2 participants