Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdg is deprecated, renamed to xdg-base-dirs #100

Closed
jonathan-berezin opened this issue Apr 2, 2024 · 10 comments
Closed

xdg is deprecated, renamed to xdg-base-dirs #100

jonathan-berezin opened this issue Apr 2, 2024 · 10 comments
Labels
wontfix This will not be worked on

Comments

@jonathan-berezin
Copy link

The PyPI project description for xdg says the following:

"""xdg has been renamed to xdg-base-dirs due to an import collision with PyXDG. Therefore the xdg package is deprecated. Install xdg-base-dirs instead.
"""

The PyPI project description for xdg-base-dirs makes a corresponding warning.

References:
https://pypi.org/project/xdg/
https://pypi.org/project/xdg-base-dirs/

@davep
Copy link
Contributor

davep commented Apr 2, 2024

xdg-base-dirs is Python>=3.10; Frogmouth supports Python 3.8 and above. There are no substantial changes in xdg-base-dirs vs xdg and pinning to xdg is recommended by the maintainer themselves.

If/when Frogmouth becomes Python>=3.10 it will likely swap to xdg-base-dirs.

@davep davep closed this as completed Apr 2, 2024
@davep davep added the wontfix This will not be worked on label Apr 2, 2024
@jonathan-berezin
Copy link
Author

Awesome! The more you know. I was browsing/admiring the codebase here, hadn't encountered xdg before, looked it up, and thought it was the right thing to do to raise a flag! I'm glad there's no issue.

@davep
Copy link
Contributor

davep commented Apr 2, 2024

No worries: much better to raise the issue and be sure, so very much appreciated.

@gl-yziquel
Copy link

@jonathan-berezin I made a PR for that change you requested: #113.

I need that to get it packaged as a debian package in my local workflow (and get xdg-base-dirs packaged too).

@davep It does indeed requires python >= 3.10. What is wrong with not being 3.8 compatible ? If 3.8 is a must, then I guess it should not be too much of a problem to use pyxdg and not xdg-base-dirs. At least until frogmouth gets 3.10 compatible.

@davep
Copy link
Contributor

davep commented Feb 2, 2025

@gl-yziquel Back when this issue was raised Python 3.8 wasn't yet EOL, and the brief for Frogmouth was to stay compatible with all supported Python versions (like Textual).

I can't speak to if this is still a requirement as I'm no longer a maintainer of this application.

@gl-yziquel
Copy link

@davep who is the maintainer of this application ?

@davep
Copy link
Contributor

davep commented Feb 2, 2025

Sorry, I don't know; you'd probably need to direct that question at the company who own the organisation.

@gl-yziquel
Copy link

@davep Hmmmhh.... smell like politics. OK. Thank you.

@davep
Copy link
Contributor

davep commented Feb 2, 2025

I'm afraid your sense of smell is off. I literally don't know the answer so I can't give you something I'm not in possession of. I have however pointed you to where you can get the answer.

@gl-yziquel
Copy link

@davep thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants