Fix loading local documents #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textual changed the way that we load markdown documents; before the
loadmethod ate all exceptions and just returnedTrueorFalse, there's since been a change where we don't do that any more and instead bubble up any exceptions. This, in turn, broke Frogmouth's ability to sense that it had managed to load a local file.Thanks to @mBaratta96 in #74 for flagging this up.
This PR fixes that issue, and also pins Textual to a specific version. Until now we've tended to let Frogmouth use whatever the latest and greatest is, but it itself is stable enough that we should not let it run into breaking changes in Textual out in the wild.