-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 13 darkmode switching #1613
Comments
@grangej - Currently working through this. The best tip I can give you currently is that layerBacked nodes seems to have the most issues. I'm applying changes in Make sure you're using the latest commits on master since I've upstreamed a few PRs that do things like setting backgroundColors using UIColor vs CGColor and adding tintColor support for ASImageNode/ASButtonNode/ASTextNode{1,2} |
iOS13 GM is already released |
thanks for your works 👍 @rahul-malik |
@ruixingchen - thanks for the comment. everything should be shippable at this point. A few things that I didn't mention before:
|
Hi @rahul-malik, |
@choiapril6 for current time I use reloadData() on my list view and re-set any dark color or image manually in other nodes, the auto-refresh is not reliable enough for me, even the master branch has many problems like the tableNode insert animation issue |
@rahul-malik Hello! In the last version Texture |
Hi ! Can someone please help to explain how to properly switch nodes color on trait switch? What is the high level recommendation from the texture team to get all child nodes to switch colors when the darkmode changes? We understand we need to listen for trait changes but this doesn't seem to be enough to get all the child nodes to switch properly. Any help would be gratefully appreciated.
The text was updated successfully, but these errors were encountered: