From 55ff2623110ef90b9082535a9e89b136c0b9b57d Mon Sep 17 00:00:00 2001 From: wiseoldduck Date: Wed, 28 Nov 2018 21:15:05 +0000 Subject: [PATCH 1/2] Access thread safe property to avoid assertion after the ASDisplayNode's view or layer have been created. --- Source/ASButtonNode.mm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Source/ASButtonNode.mm b/Source/ASButtonNode.mm index 46bec93c5..5ec1f2371 100644 --- a/Source/ASButtonNode.mm +++ b/Source/ASButtonNode.mm @@ -16,6 +16,7 @@ #import #import #import +#import @interface ASButtonNode () { @@ -543,7 +544,7 @@ - (ASLayoutSpec *)layoutSpecThatFits:(ASSizeRange)constrainedSize - (NSString *)defaultAccessibilityLabel { ASLockScopeSelf(); - return _titleNode.accessibilityLabel; + return _titleNode.defaultAccessibilityLabel; } - (UIAccessibilityTraits)defaultAccessibilityTraits From 42c1065fa3c83bbb043454f5962cc6bc6bc8be79 Mon Sep 17 00:00:00 2001 From: Kevin Smith Date: Thu, 13 Dec 2018 10:11:39 -0800 Subject: [PATCH 2/2] Oops add these headers --- Source/ASTextNode.h | 1 + Source/ASTextNode2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/Source/ASTextNode.h b/Source/ASTextNode.h index e3830a155..783eafc53 100644 --- a/Source/ASTextNode.h +++ b/Source/ASTextNode.h @@ -10,6 +10,7 @@ #import #import +#import #import #if (!AS_ENABLE_TEXTNODE) diff --git a/Source/ASTextNode2.h b/Source/ASTextNode2.h index 177751610..254ce40a7 100644 --- a/Source/ASTextNode2.h +++ b/Source/ASTextNode2.h @@ -7,6 +7,7 @@ // #import +#import #import @protocol ASTextLinePositionModifier;