Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 19 #5

Open
acho1833 opened this issue Jan 5, 2025 · 2 comments
Open

Update to React 19 #5

acho1833 opened this issue Jan 5, 2025 · 2 comments

Comments

@acho1833
Copy link

acho1833 commented Jan 5, 2025

By all means, thank you so much for setting this template!. I really love the tech choices you have (especially zod-openapi and hono)

I'm trying to deploy with base code but keep getting

npm error   peer react@">=16.8.0" from @hookform/[email protected]
npm error   node_modules/@hookform/error-message
npm error     @hookform/error-message@"^2.0.1" from the root project
npm error   peer react@"^19.0.0" from [email protected]
npm error   node_modules/react-dom
npm error     peer react-dom@">=16.8.0" from @hookform/[email protected]
npm error     node_modules/@hookform/error-message
npm error       @hookform/error-message@"^2.0.1" from the root project
npm error   1 more (react-hook-form)

I am attempting to fix one by one but this error message seems to show up on another package. I would definitely appreciate if it can be updated. If not, that's fine and I'll eventually upgrade to latest version. Thanks!

@TheBinaryGuy
Copy link
Owner

Hey, thanks for the kind words and trying the template out!
Sorry, I was traveling so didn't have time to catch up with issues.

But I just pushed out an update and the repo now has updated deps (except for eslint, still at v8).
Hopefully, this fixes your issue.

If you still encounter problems when cloning / installing deps and are using npm, I'd recommend using --force or --legacy-peer-deps or switching to pnpm, see more here;
https://ui.shadcn.com/docs/react-19#how-to-fix-this

@TheBinaryGuy
Copy link
Owner

Hey @acho1833, sorry to ping, does the update resolve your issue, and if so should I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants