Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Vite not running #26351

Closed
1 of 2 tasks
Haswell-s opened this issue Sep 18, 2023 · 7 comments · Fixed by #26385
Closed
1 of 2 tasks

React: Vite not running #26351

Haswell-s opened this issue Sep 18, 2023 · 7 comments · Fixed by #26385
Assignees
Labels
Content: React Involves the React course Type: Good First Issue Good for beginner contributors

Comments

@Haswell-s
Copy link

Haswell-s commented Sep 18, 2023

Describe your suggestion

In the current lts version of node, the latest vite version throws an error.
as stated in this issue, vite can be run on node version 20.6.1.
Easily fixed it by running nvm install node.
Maybe add a temporary notice?

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-react-new-setting-up-a-react-environment

Checks

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@01zulfi
Copy link
Member

01zulfi commented Sep 20, 2023

@i5x64BIT We have learners install Node's LTS version in the earlier installation lesson (which is v18.18.0 currently). Does this bug persist on Node's LTS version?

@01zulfi 01zulfi added the Content: React Involves the React course label Sep 20, 2023
@Haswell-s
Copy link
Author

Haswell-s commented Sep 20, 2023

@01zulfi Yes, it is some problem between the latest Vite and the LTS version of node.
So either we should ask the students to install a specific version of vite or the latest of nodejs.

@01zulfi
Copy link
Member

01zulfi commented Sep 23, 2023

I'm unable to reproduce any errors on the Node's LTS version 18.18.0.

Commands I used for Vite w/ Vite version 4.4.5:

# this is the command we use in the curriculum
npm create vite@latest my-first-react-app -- --template react

cd my-first-react-app

npm install
npm run dev
npm run build

None of the above gave any errors and worked as expected. Though I did get the this error on Node 20.6.0

@i5x64BIT, please confirm. Also, what do you think we should do? Maybe a reminder in the setting up React lesson to use Node LTS?

@Haswell-s
Copy link
Author

@01zulfi Yep, just leave a note about a possible conflict.

@01zulfi
Copy link
Member

01zulfi commented Sep 24, 2023

Sounds good.

I'm opening the issue up for contribution. Acceptance criteria as follows:

  • Add a sentence in setting up a React env lesson right before the npm create ... command:
    • It needs to be something along the lines of, "Please make sure that you're on Node's LTS version.'

@01zulfi 01zulfi added Type: Good First Issue Good for beginner contributors Status: Help Wanted This issue can be assigned to other contributors labels Sep 24, 2023
@ScaxCodes
Copy link
Contributor

Good morning, ☕
Would you assign me to this issue? I'd like to fix it. It would be my first contribution on github.

I've read the contribution guide. ✅

@01zulfi
Copy link
Member

01zulfi commented Sep 25, 2023

Thanks @ScaxCodes, I've assigned the issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course Type: Good First Issue Good for beginner contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants