Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails - Advanced Forms and Active Record: Update section numbers indicated in the Assignment #29073

Closed
3 tasks done
bellitabellota opened this issue Nov 12, 2024 · 2 comments · Fixed by #29149
Closed
3 tasks done
Assignees

Comments

@bellitabellota
Copy link
Contributor

Checks

Describe your suggestion

image

  1. In "Querying basics“ bullet point 3 needs to be updated

    Currently:
    Section 7 is about Grouping
    Section 8 is about Overriding Conditions
    Section 21 is about Calculations

    So rather than Section 8, I guess it is another section we should read in this context.

  2. In "Querying basics“ bullet point 4 needs to be updated

    According to this bullet point, we should read 3 sections about "overriding conditions".

    Currently:
    Section 9 is about Null Relation
    Section 10 is about Readonly Objects
    Section 11 is about Locking Records for Update
    Section 12 is about Joining Tables

  3. In "Advanced querying“ bullet point 2 may need to be updated

    Section 19 is about Finding by SQL

    Is this section indeed the one that we are meant to read to learn about „using SQL directly to query"?


As it seems that the order and numbering of the sections at https://guides.rubyonrails.org/active_record_querying.html has changed, I am a bit worried that we might miss any important new information in this lesson.

In case I can help resolving this issue I'd be happy to contribute but I am not sure how those sections numbers should be updated.

Path

Ruby / Rails

Lesson Url

https://www.theodinproject.com/lessons/ruby-on-rails-active-record-queries

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@JoshDevHub
Copy link
Contributor

Thank you for making this issue @bellitabellota and sorry for the delay on our end for looking at it.

Here is how the items should be updated:

  • Querying Basics 3: Read sections 7 and 21 to learn about grouping and aggregate functions.
  • Querying Basics 4: Skim section 8 to learn about overriding conditions.

Your last point is the correct section for learners to read for finding by SQL. If you would like to suggest a rewording to make this more clear, I would be glad to take a look.

Since you indicated you'd like to work on this, I'll assign you. Let me know if you have any questions.

@bellitabellota
Copy link
Contributor Author

Perfect, I will create a pull request for these changes.
Thank @JoshDevHub you for taking the time and helping with updating the assignment instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants