-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"controls" support for ios & "fullscreen" support for Android #369
Comments
Added a $100 bounty for this, because I really need these features https://www.bountysource.com/issues/38797648-controls-support-for-ios-fullscreen-support-for-android |
@louislai Please check, i have finally made fullscreen work on android, check your bounty page |
controls={true} in android can work... i write the control code by myself. |
Guys check out my example code: I believe this is what you want although it comes a little late, I see this issue just now, in issue #534 , I also posted my solution. |
Is this bounty still up for taking? |
Opened a PR (#1730) for full-screen support in Android Exoplayer. |
Right now, react-native-video supports opening a fullscreen player on ios using
presentFullScreenPlayer
, but this option is missing in android. Similarly, I can toggle a native player controls using thecontrols
prop, but this only works on Android.Would be really nice if someone can implement native controls in iOS, and fullscreen player for Android inside the react-native-video package.
I tried to hack together a fullscreen player for android by creating a new Activity with a SurfaceView to display the video output. To stop the video from reloading I store the MediaPlayer object as a singleton https://github.com/louislai/react-native-video/blob/master/android/src/main/java/com/brentvatne/react/FullScreenVideoActivity.java
However, I hope that someone can give a more general and proper solution.
The text was updated successfully, but these errors were encountered: