Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Improved fix for broken test test-use_readme.R #1121

Closed
ilyaZar opened this issue Nov 30, 2023 · 1 comment
Closed

[FR] Improved fix for broken test test-use_readme.R #1121

ilyaZar opened this issue Nov 30, 2023 · 1 comment

Comments

@ilyaZar
Copy link
Contributor

ilyaZar commented Nov 30, 2023

Via 9ad9775 a test fix for test-use_readme() is done that skips the test in non-interactive mode.

However, when eliminating the devtools:::build_readme() call at the very end, the test passes successfully in non-interactive mode, so no need for skipping.

Hence, to improve codecov one may delete the devtools:::build_readme() line and run the test as usual.

Can be fixed via #1122

@ColinFay
Copy link
Member

ColinFay commented Aug 7, 2024

This has been closed via #1131

@ColinFay ColinFay closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants