Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates #146

Merged
merged 23 commits into from
Sep 5, 2024
Merged

CI updates #146

merged 23 commits into from
Sep 5, 2024

Conversation

0815Creeper
Copy link
Contributor

version bumps in github actions,
switch from artifacts to commit-based example upload,
check for example build success

0815Creeper and others added 13 commits August 12, 2024 12:00
* Update Example.yml

Added check for success of jupyter examples, fail action if example-building fails, prevents autocommit to examples branch

* relaxed compats

Update Project.toml

---------

Co-authored-by: ThummeTo <[email protected]>
see breaking changes of actions/upload-artifact@v4
due to changes in artifact behavior
@0815Creeper
Copy link
Contributor Author

ready to merge

@ThummeTo
Copy link
Owner

just checking if DifferentialEquations 7.13 works

@0815Creeper
Copy link
Contributor Author

now the failing examples use DifferentialEquations 7.13 but still failing due to (upgradable) BoundaryValueDiffEq v5.7.1
any further ideas?

@0815Creeper
Copy link
Contributor Author

will FMIFlux.jl move away from DifferentialEquations.jl (just as FMI.jl) soon or not? if not, this needs fixing

@ThummeTo
Copy link
Owner

ThummeTo commented Aug 29, 2024

see feature branch v0.13.0 :-)
(answer is yes, it's OrdinaryDiffEq now)

@0815Creeper
Copy link
Contributor Author

just found the possible source of the issue: some other recursive dependent packages, that prevent BoundaryValueDiffEq from updated. The only reasonable solution is to limit BoundaryValueDiffEq to 5.6 manually within the action.
Not pretty but for now the best solution, I think

0815Creeper and others added 6 commits August 29, 2024 14:58
dont use "latest" in workflows
dont use "latest" in workflows
dont use "latest" in workflows
dont use "latest" in workflows
@ThummeTo ThummeTo merged commit 322f028 into ThummeTo:main Sep 5, 2024
6 of 11 checks passed
@0815Creeper 0815Creeper deleted the 0815Creeper-patch-1 branch September 8, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants