Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NAN 2.0 broke functionality #75

Open
jeisinger opened this issue Apr 15, 2016 · 0 comments
Open

Update to NAN 2.0 broke functionality #75

jeisinger opened this issue Apr 15, 2016 · 0 comments

Comments

@jeisinger
Copy link

The update to NAN 2.0 changed the usage of nan's SetWeak to using WeakCallbackType::kParameter. The latter only triggers a callback after the object was collected. So taking a reference to that object doesn't work anymore.

I'm introducing kFinalizer in the v8 API so you can get the old behavior, but until then, you should consider going back to the (deprecated) API you used before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant