Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skia to m87 #196

Closed
flsobral opened this issue Nov 10, 2020 · 8 comments
Closed

Update Skia to m87 #196

flsobral opened this issue Nov 10, 2020 · 8 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@flsobral
Copy link
Member

TotalCross is using Skia m71, which is almost 2 years old?
Updating Skia is important to keep up with the latest fixes and upgrades.

@flsobral flsobral added the feature New feature or request label Nov 10, 2020
@flsobral
Copy link
Member Author

flsobral commented Nov 10, 2020

Skia m87 successfully built for Linux, MacOS and Android.
TotalCross build updated from C++11 to C++14 to meet Skia requirements.
Fixed TotalCross' drawing text primitives - Skia had some breaking changes.

Current state:

  1. Material Icons are not being displayed on any platform, will check if this is a regression or a bug that wasn't noticed before;
  2. Performance in Linux desktop is not great, will compare with previous version to measure the actual difference;
  3. Text is not correctly displayed on Linux desktop: text is not centered and sometimes truncated;

@brunoamuniz
Copy link

@flsobral any update on this? =)

@acmlira
Copy link
Contributor

acmlira commented Nov 24, 2020

Skia has been successfully built for all platforms as far as I know. I also know that @Farshid-Monhaseri and I were working on some optimizations. @flsobral can give us more information.

@Farshid-Monhaseri Farshid-Monhaseri self-assigned this Nov 24, 2020
@flsobral
Copy link
Member Author

flsobral commented Nov 30, 2020

Built for Android, iOS, MacOSX, Linux x86_64 and arm64.
Working on build for armv7 - out latest try failed to build the libtcvm.

@Farshid-Monhaseri
Copy link
Collaborator

Building libtcvm was done with Skia m87 ... we are on testing it and maybe tweak some of the configs for each platform.

@acmlira
Copy link
Contributor

acmlira commented Dec 7, 2020

We are very close to closing the issue, now we are organizing the commits and doing the final tests before integrating.

@teras
Copy link
Collaborator

teras commented Dec 23, 2020

Is this issue fixed? Should we close this issue?

@acmlira
Copy link
Contributor

acmlira commented Dec 23, 2020

#224 was merged i think we can close this one.

@acmlira acmlira closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants