Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary panic on Message enum match arms #319

Closed
ArchangelJTW opened this issue May 7, 2024 · 2 comments · Fixed by #320
Closed

Unnecessary panic on Message enum match arms #319

ArchangelJTW opened this issue May 7, 2024 · 2 comments · Fixed by #320
Assignees
Labels
C-Bug Something isn't working

Comments

@ArchangelJTW
Copy link

Describe the bug
Some of the match arms for tungstenite's Message enum in engineioxide/src/transport/ws.rs line 194 are not done, and therefore panic! I don't think it should panic, because some libraries use the other message variants, for example Pong. The catchall should just log to tracing instead of panicking.

To Reproduce
Steps to reproduce the behavior:
Try a client (doghappy's C# SocketIOClient) that uses the other message enum variants

Expected behavior
Not panicking for no reason

Versions (please complete the following information):

  • Socketioxide version: v0.13.0
  • Http lib: salvo v0.67.0
  • Socket.io client version: V4

Additional context
There is none, thanks

@ArchangelJTW ArchangelJTW added the C-Bug Something isn't working label May 7, 2024
@acfsmith
Copy link

acfsmith commented May 8, 2024

I have the same problem with my client application written in Flutter. Apart from frequent panics, Socketioxide works just fine.

@Totodore
Copy link
Owner

Totodore commented May 8, 2024

Fixed with v0.13.1. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Something isn't working
Projects
None yet
3 participants