You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Some of the match arms for tungstenite's Message enum in engineioxide/src/transport/ws.rs line 194 are not done, and therefore panic! I don't think it should panic, because some libraries use the other message variants, for example Pong. The catchall should just log to tracing instead of panicking.
To Reproduce
Steps to reproduce the behavior:
Try a client (doghappy's C# SocketIOClient) that uses the other message enum variants
Expected behavior
Not panicking for no reason
Versions (please complete the following information):
Socketioxide version: v0.13.0
Http lib: salvo v0.67.0
Socket.io client version: V4
Additional context
There is none, thanks
The text was updated successfully, but these errors were encountered:
Describe the bug
Some of the match arms for tungstenite's
Message
enum in engineioxide/src/transport/ws.rs line 194 are not done, and therefore panic! I don't think it should panic, because some libraries use the other message variants, for example Pong. The catchall should just log to tracing instead of panicking.To Reproduce
Steps to reproduce the behavior:
Try a client (doghappy's C# SocketIOClient) that uses the other message enum variants
Expected behavior
Not panicking for no reason
Versions (please complete the following information):
Additional context
There is none, thanks
The text was updated successfully, but these errors were encountered: