Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Town "Friend" List #165

Closed
LlmDl opened this issue Aug 23, 2015 · 12 comments
Closed

Town "Friend" List #165

LlmDl opened this issue Aug 23, 2015 · 12 comments

Comments

@LlmDl
Copy link
Member

LlmDl commented Aug 23, 2015

Originally reported on Google Code with ID 128

I suggest you add a system to allow mayors and assistants to add players to the towns
friend list (/town add friend) (/town list friend) or something like that.

Then add a new set of permissions to the existing permissions of outsider,ally, and
resident. This permission would allow you to have "trusted" players from other towns
build in your town which would be very useful. A lot of servers have towns that are
friendly with each other and help each other out, it would be nice to be able to allow
these people to build in your town (just like residents can do on a plot level).

Seems like almost all the code exists to do this, would just need to be implemented
=)

Thanks for your time and the great plugin!




Reported by Jheifner89 on 2011-08-03 17:37:54

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

Reported by Hurfapotamus on 2011-08-04 02:01:42

  • Labels added: Label-Town, Label-Mayor

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

Issue 197 has been merged into this issue.

Reported by [email protected] on 2011-08-22 16:24:05

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

This would be the ally permissions and they are used via nations which are a collection
of "friend" towns

Reported by [email protected] on 2011-09-01 07:41:43

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

This is very different from ally permissions. Allies involves nations and allied towns.
This would just be towns and allied players, lets say a few people make a small town
and want to let a friend help them even though he is in another town. That isn't possible
at the time without changing your settings to allow outsiders (dangerous) to build.

That is the purpose of this feature!

Reported by Jheifner89 on 2011-09-01 15:47:36

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

Yep, would be really useful to let a single user help you without letting his whole
town changuing yours.

Sorry about english gramar :S (i think i made my point)

Reported by trollkemada on 2011-09-01 16:40:20

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

I don't think this is ever going to be added =( Even though the dev told me It would
be added after the update that came out early august... Never got added =(

Reported by Jheifner89 on 2012-01-24 20:36:11

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

Technical analysis:

TownFriends have no effect during war = fuck, can't use isAlly(Res, ____). Would probably
need to write a isAlly(Res, Town) anyways though. It would first check town.residentAllies.contains(res)
before then calling isAlly(res.town, town).
Probably need to make a parseResidentsLine(String) -> List<Resident> for the persistance.
And vice versa.

Yay for expanding the permissions table by a column. Does that still work nice in /town
status or does that fail horribly causing us to rethink the view.

Does this for for nations isAlly() as well? No. It should only be used for that town
checks otherwise possible abuse from another town in the nation. People will probably
beg for this option anyways so plan on making a trusted list in nation as well. Yay
more copy pasta (as the persistance code is a joke atm and uses no form of inheritance).

Would this change PvP state? No. As you might decide on trusting an ally (your own
fault) so you should be able to kill him.

Um. Not possible to make embassy plots (would just be extra work and in no way part
of this request but someone will eventually ask for it so glance at how hard it'll
be, including proper cleanup when 'untrusted').

Oh don't forget add/remove trusted commands. Probably copypasta again but then there's
the lang additions as well. Probably should create an abstract method for the two (and
others that probably do the same thing).

Reported by zrenfire on 2012-01-25 04:25:14

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

erm not = fuck. It's really more that we can't use an existing method, which kinda makes
sense after i got going deeper into logic mode.

Reported by zrenfire on 2012-01-25 04:27:19

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

This is the job of nations and the allies setting.

Reported by [email protected] on 2012-01-25 13:19:54

  • Status changed: Need_Feedback

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

It IS a good idea. It's just a fair amount of work.

Reported by zrenfire on 2012-01-25 15:40:12

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

We get by with nations and allies but sometimes towns that are NOT part of nations want
to let friends help them build or with a short term project.

Reported by Jheifner89 on 2012-01-25 16:34:59

@LlmDl
Copy link
Member Author

LlmDl commented Aug 23, 2015

Merging this with 856. It's a later ticket but does have promise.

Reported by [email protected] on 2012-04-11 11:11:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant