Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly Rust toolchain for Bazel #456

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update nightly Rust toolchain for Bazel #456

merged 1 commit into from
Dec 8, 2023

Conversation

jaroeichler
Copy link
Contributor

@jaroeichler jaroeichler commented Dec 7, 2023

Fixes #374

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Bazel build from within Nix with nightly config.

Checklist

  • Updated documentation if needed
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Contributor Author

@jaroeichler jaroeichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion


native-link-store/tests/filesystem_store_test.rs line 313 at r1 (raw file):

        let mut read_dir_stream = ReadDirStream::new(temp_dir_handle);

        if let Some(temp_dir_entry) = read_dir_stream.next().await {

This doesn't change the logic. But I'm not sure if it's intended this way.

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jaroeichler)


native-link-store/tests/filesystem_store_test.rs line 313 at r1 (raw file):

Previously, jaroeichler wrote…

This doesn't change the logic. But I'm not sure if it's intended this way.

Yeah this is fine, since we are panic-ing it is ok to use if instead of while.

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR!

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jaroeichler)

@aaronmondal aaronmondal merged commit 5acfa25 into TraceMachina:main Dec 8, 2023
15 checks passed
@jaroeichler jaroeichler deleted the update-nightly branch July 29, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nightly rust version for sanitizers
4 participants