Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing timeouts in tests #553

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix missing timeouts in tests #553

merged 1 commit into from
Dec 20, 2023

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Dec 20, 2023 •
edited by allada
Loading

Explicit short timeouts prevent tests from running indefinitely.

This change is Reviewable

@aaronmondal
Fix missing timeouts in tests
2193bf1 
Explicit short timeouts prevent tests from running indefinitely.
aaronmondal
aaronmondal commented Dec 20, 2023
View reviewed changes
Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@allada +@adam-singer

Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Bazel Dev / large-ubuntu-22.04, Cargo Dev / large-ubuntu-22.04, Local / large-ubuntu-22.04, Remote / large-ubuntu-22.04, asan / large-ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), large-ubuntu-20.04 / stable, large-ubuntu-22.04, large-ubuntu-22.04 / stable, publish-image, windows-2022 / stable (waiting on @adam-singer and @allada)

allada
allada approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: 1 of 2 LGTMs obtained, and pending CI: Bazel Dev / large-ubuntu-22.04, Cargo Dev / large-ubuntu-22.04, Local / large-ubuntu-22.04, Remote / large-ubuntu-22.04, asan / large-ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), large-ubuntu-22.04, publish-image, windows-2022 / stable (waiting on @adam-singer)

@aaronmondal aaronmondal merged commit c54c51c into TraceMachina:main Dec 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allada allada allada approved these changes

Assignees

@allada allada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronmondal @allada @adam-singer