[BREAKING] Add concurrency limit to GRPC #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisstaite-menlo
requested review from
allada and
aaronmondal
and removed request for
allada
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Currently we apply no concurrency limits for GRPC calls to GrpcStore or GrpcScheduler. This can cause issues for a heavily loaded upstream service that will start to build up reset streams and break. This change modifies the configuration to have configuration per endpoint and adds an optional configuration to allow for setting a limit to the upstream concurrency.
chrisstaite-menlo
force-pushed
the
grpc_concurrency
branch
from
0f6153c to
e195915
Compare
adam-singer
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
aaronmondal
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
aaronmondal
approved these changes
Jan 25, 2024
|
I wasn't sure if this required a documentation change, or where said documentation is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we apply no concurrency limits for GRPC calls to GrpcStore or GrpcScheduler. This can cause issues for a heavily loaded upstream service that will start to build up reset streams and break.
This change modifies the configuration to have configuration per endpoint and adds an optional configuration to allow for setting a limit to the upstream concurrency.
Fixes #320
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Local cluster.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is