Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate K8s HTTPRoutes to GRPCRoutes #868

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Apr 19, 2024

This way we can make use of pure grpc routing.

Includes some hardening for newer docker daemons which might use dual-stack ip subnets.

Fixes https://github.com/TraceMachina/nativelink/security/dependabot/31


This change is Reviewable

This way we can make use of pure grpc routing.

Includes some hardening for newer docker daemons which might use
dual-stack ip subnets.

Fixes https://github.com/TraceMachina/nativelink/security/dependabot/31
Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@adam-singer

Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @adam-singer)

@aaronmondal aaronmondal linked an issue Apr 19, 2024 that may be closed by this pull request
Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@aaronmondal aaronmondal merged commit 7e379ff into TraceMachina:main Apr 19, 2024
26 checks passed
chinchaun pushed a commit to chinchaun/nativelink that referenced this pull request May 6, 2024
This way we can make use of pure grpc routing.

Includes some hardening for newer docker daemons which might use
dual-stack ip subnets.

Fixes https://github.com/TraceMachina/nativelink/security/dependabot/31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pure HTTP2 (non-upgrade) doesn't work
2 participants