Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to DataFrames v0.22 #57

Closed
khosravipasha opened this issue Nov 22, 2020 · 1 comment
Closed

Move to DataFrames v0.22 #57

khosravipasha opened this issue Nov 22, 2020 · 1 comment
Assignees
@khosravipasha
Labels
low priority low priority

Comments

@khosravipasha
Copy link
Collaborator

Few things are deprecated in this version and since we run ---depwarn=error our tests fail. Otherwise the code runs but gives out depracted warnings.

Options:

  1. Remove --depwarn=error
  2. Make the changes, might not be that big, but also might break w.r.t older versions of dataframes
@khosravipasha khosravipasha added the low priority low priority label Nov 22, 2020
@khosravipasha khosravipasha self-assigned this Nov 22, 2020
@khosravipasha khosravipasha linked a pull request Nov 22, 2020 that will close this issue
CompatHelper: bump compat for "DataFrames" to "0.22" #56
Closed
@khosravipasha
Copy link
Collaborator Author

Changes for option 2 are already done here: #56
Just need to decide to push it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khosravipasha khosravipasha

Labels
low priority low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CompatHelper: bump compat for "DataFrames" to "0.22" Tractables/LogicCircuits.jl
1 participant
@khosravipasha