Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Issues with traversal infra, counters #64

Closed
khosravipasha opened this issue Jan 21, 2021 · 1 comment
Closed

Potential Issues with traversal infra, counters #64

khosravipasha opened this issue Jan 21, 2021 · 1 comment

Comments

@khosravipasha
Copy link
Collaborator

khosravipasha commented Jan 21, 2021

  1. foreach_down had some unexpected behaviour
  2. reset_counter might not work in all cases

And overall want a more reliable way of reseting the travesals without having to reload the circuit again.

@guyvdbroeck
Copy link
Member

I added reset_counter_hard in fbdedf2
It resets the counter even if the nodes' fields are messed up (but is slower than the default implementation).

julia> circuit = load_smooth_logic_circuit(zoo_psdd_file("plants.psdd"));

julia> @btime (reset_counter(circuit,1);reset_counter(circuit,0))
  46.723 ms (0 allocations: 0 bytes)

julia> @btime (reset_counter_hard(circuit,1);reset_counter_hard(circuit,0))
  73.743 ms (540960 allocations: 14.26 MiB)

I believe this closes the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants