Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature request) Move Promoted Attributes to Sidebar #869

Open
BeatLink opened this issue Dec 31, 2024 · 3 comments
Open

(Feature request) Move Promoted Attributes to Sidebar #869

BeatLink opened this issue Dec 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@BeatLink
Copy link

Describe feature

With #538 now implemented, it would be great if all promoted attributes could be moved to the right sidebar to take advantage of horizontal screen real estate

Additional Information

No response

@eliandoran eliandoran added the enhancement New feature or request label Jan 2, 2025
@eliandoran
Copy link
Contributor

@BeatLink , I'm not sure if it's a good idea to add them to the sidebar. I'm more inclined toward how Notion handles their equivalent of promoted attributes, which is underneath the title bar.

@BeatLink
Copy link
Author

BeatLink commented Jan 6, 2025

What about a toggle to let the user choose?

@eliandoran
Copy link
Contributor

eliandoran commented Jan 6, 2025

@BeatLink , toggles are quite expensive in terms of maintenance. From the moment you add it you now have two more branches in the application. If you make a single change in the promoted attributes (even small changes such as changing a margin), now you have to test then in both scenarios.

We already added a toggle for the horizontal layout vs vertical layout and it brought a pretty significant cost in terms of maintenance.

So I would rather pick one and go with it. Maybe adding a toggle/expand button to the existing implementation would also help.

What would be the use case of having promoted attributes in the sidebar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants