Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails on node 12 #16

Open
bahamas10 opened this issue Jul 16, 2015 · 0 comments
Open

fails on node 12 #16

bahamas10 opened this issue Jul 16, 2015 · 0 comments

Comments

@bahamas10
Copy link

fresh clone

$ git clone [email protected]:joyent/v8plus.git
Cloning into 'v8plus'...
cd vremote: Counting objects: 295, done.
remote: Total 295 (delta 0), reused 0 (delta 0), pack-reused 295
Receiving objects: 100% (295/295), 137.01 KiB | 0 bytes/s, done.
Resolving deltas: 100% (185/185), done.
Checking connectivity... done.

install npm deps

$ cd v8plus
v8plus $ npm install
/

fail to compile example

v8plus $ cd examples
v8plus/examples $ make
NODE_PATH=../node_modules /opt/local/bin/node ../generrno.js -h -o v8plus_errno.h ../errno.json
/opt/local/bin/gcc  -DBUILDING_NODE_EXTENSION -DMODULE=example -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPIC -isystem /opt/local/include/node -I. -I.. -g -Wall -Wextra -Werror -fPIC -O2 -std=c99 -c -o example.o example.c
/opt/onbld/bin/i386/ctfconvert -l v8plus_0.3.0 example.o
/opt/local/bin/gcc -D_GNU_SOURCE -D__EXTENSIONS__ -DBUILDING_NODE_EXTENSION -DMODULE=example -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPIC -isystem /opt/local/include/node -I. -I.. -g -Wall -Wextra -Werror -fPIC -O2 -std=c99 -c -o v8plus_csup.o ../v8plus_csup.c
../v8plus_csup.c: In function 'v8plus_crossthread_init':
../v8plus_csup.c:333:6: error: passing argument 3 of 'uv_async_init' from incompatible pointer type [-Werror]
In file included from ../v8plus_csup.c:14:0:
/opt/local/include/node/uv.h:753:15: note: expected 'uv_async_cb' but argument is of type 'void (*)(struct uv_async_t *, int)'
cc1: all warnings being treated as errors
../Makefile.v8plus.targ:27: recipe for target 'v8plus_csup.o' failed
make: *** [v8plus_csup.o] Error 1

system

dave - arbiter sunos ~ $ uname -a
SunOS arbiter.rapture.com 5.11 joyent_20150709T171818Z i86pc i386 i86pc Solaris
dave - arbiter sunos ~ $ node -v
v0.12.5
dave - arbiter sunos ~ $ node -pe process.arch
ia32

NOTE: this works on node 10

@jclulow jclulow self-assigned this May 15, 2016
@jclulow jclulow removed their assignment Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants