-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on Ruby #1346
Comments
Related: #1021 (for reference). |
We do not want to add any more native binary dependencies to Ghost, thus we have been waiting for the work on including binaries in node-sass to be finished before doing this. I believe that is now finished, but we need to be certain it will work on all major platforms before switching dependencies otherwise there's little point. @andrew who is the maintainer of node-sass has tested things out with Ghost - I don't think he had any problems so maybe he knows more about how to circumvent the |
0.7.0 shipped last week (https://github.com/andrew/node-sass/releases/tag/v0.7.0) and I've not seen any install errors reported so far, which is good. Libsass is moving quite slowly at the moment, so it's unlikely there will be all the latest and great features available in Sass 3.3 for a few months, which might be a block for the design community (or a constant source of bug reports). Switching from ruby sass to node-sass is as simple as this: andrew@f6b0c1d |
@andrew tbh the overwhelming majority of the work in sass is just me - and we only use it in admin - so it's not likely to block many other people for a while! :) Can you PR your change? |
It's not quite that easy, |
There is an outputStyle option: grunt.initConfig({
sass: {
dev: {
options: {
outputStyle: 'compressed'
}
}
}
}); The comments about it may be outdated, need to check. |
Defo need to keep compression :) |
In order to make the switch we need to:
I've had a little go, but unfortunately it doesn't properly convert our sass to css, due to several issues which have been open on libsass for a very long time: sass/libsass#80 Unless libsass takes a giant leap forward, I don't see that we're going to be able to make the switch any time soon. Which is very sad 😿 |
I second the move, ruby was a barrier to me to start contributing to ghost. However - I understand the need for compatibility. |
Unless someone familiar with c / c++ wants to dive into libsass and get it up-to-date, we're stuck with Ruby for the time being. Perhaps this is something @mjbshaw might be interested in? C/C++ work that would massively improve Ghost. |
Overlooked this email in my inbox. I'll start digging into libsass :) |
Just want to reference #1021 for discoverability. And leave my +1 on getting rid of ruby ;) Edit: oops, already referenced. New github UI confuses me. Mea culpa. |
This has landed in @TryGhost/Ghost-UI, all further work will be done there. |
@JohnONolan any ETA on when Ghost-UI is ready for core integration? |
NO MORE RUBY 🎈 🎈 🎈 |
We can switch to using
grunt-sass
(which useslibsass
) andnode-bourbon
- no Ruby required.I just started on a pull request and it seems to be working except for this issue which comes from a call to
@include
in the SASS with insufficient parameters. If we can work out where this might be coming from then I can probably submit a pull request.The text was updated successfully, but these errors were encountered: