Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Ruby #1346

Closed
simonexmachina opened this issue Oct 30, 2013 · 15 comments
Closed

Remove dependency on Ruby #1346

simonexmachina opened this issue Oct 30, 2013 · 15 comments
Milestone

Comments

@simonexmachina
Copy link

We can switch to using grunt-sass (which uses libsass) and node-bourbon - no Ruby required.

I just started on a pull request and it seems to be working except for this issue which comes from a call to @include in the SASS with insufficient parameters. If we can work out where this might be coming from then I can probably submit a pull request.

@gotdibbs
Copy link
Contributor

Related: #1021 (for reference).

@ErisDS
Copy link
Member

ErisDS commented Oct 30, 2013

We do not want to add any more native binary dependencies to Ghost, thus we have been waiting for the work on including binaries in node-sass to be finished before doing this. I believe that is now finished, but we need to be certain it will work on all major platforms before switching dependencies otherwise there's little point.

@andrew who is the maintainer of node-sass has tested things out with Ghost - I don't think he had any problems so maybe he knows more about how to circumvent the @include error?

@andrew
Copy link

andrew commented Oct 30, 2013

0.7.0 shipped last week (https://github.com/andrew/node-sass/releases/tag/v0.7.0) and I've not seen any install errors reported so far, which is good.

Libsass is moving quite slowly at the moment, so it's unlikely there will be all the latest and great features available in Sass 3.3 for a few months, which might be a block for the design community (or a constant source of bug reports).

Switching from ruby sass to node-sass is as simple as this: andrew@f6b0c1d

@JohnONolan
Copy link
Member

@andrew tbh the overwhelming majority of the work in sass is just me - and we only use it in admin - so it's not likely to block many other people for a while! :)

Can you PR your change?

@ErisDS
Copy link
Member

ErisDS commented Oct 30, 2013

It's not quite that easy, grunt-sass doesn't offer us a compression option - is that something we're happy to lose?

@andrew
Copy link

andrew commented Oct 30, 2013

There is an outputStyle option:

grunt.initConfig({
    sass: {                              
        dev: {                           
            options: {                   
                outputStyle: 'compressed'
            }
        }
    }
});

The comments about it may be outdated, need to check.

@JohnONolan
Copy link
Member

Defo need to keep compression :)

@ErisDS
Copy link
Member

ErisDS commented Oct 30, 2013

In order to make the switch we need to:

  • switch grunt-contrib-sass to grunt-sass
  • switch bourbon to node-bourbon
  • update the Gruntfile configuration for these things.

I've had a little go, but unfortunately it doesn't properly convert our sass to css, due to several issues which have been open on libsass for a very long time:

sass/libsass#80
sass/libsass#146

Unless libsass takes a giant leap forward, I don't see that we're going to be able to make the switch any time soon. Which is very sad 😿

@karlmikko
Copy link
Contributor

I second the move, ruby was a barrier to me to start contributing to ghost. However - I understand the need for compatibility.

@ErisDS
Copy link
Member

ErisDS commented Dec 18, 2013

Unless someone familiar with c / c++ wants to dive into libsass and get it up-to-date, we're stuck with Ruby for the time being.

Perhaps this is something @mjbshaw might be interested in? C/C++ work that would massively improve Ghost.

@mjbshaw
Copy link
Contributor

mjbshaw commented Dec 23, 2013

Perhaps this is something @mjbshaw might be interested in? C/C++ work that would massively improve Ghost.

Overlooked this email in my inbox. I'll start digging into libsass :)

@c089
Copy link

c089 commented Jan 29, 2014

Just want to reference #1021 for discoverability. And leave my +1 on getting rid of ruby ;) Edit: oops, already referenced. New github UI confuses me. Mea culpa.

@JohnONolan
Copy link
Member

This has landed in @TryGhost/Ghost-UI, all further work will be done there.

@halfdan
Copy link
Contributor

halfdan commented Mar 7, 2014

@JohnONolan any ETA on when Ghost-UI is ready for core integration?

@ErisDS
Copy link
Member

ErisDS commented Mar 9, 2014

NO MORE RUBY 🎈 🎈 🎈

@ErisDS ErisDS reopened this Mar 9, 2014
@ErisDS ErisDS closed this as completed Mar 9, 2014
@ErisDS ErisDS modified the milestones: 0.4.2, Future May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants