Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apps initial lifecycle and setting screen UI #2083

Closed
ErisDS opened this issue Jan 30, 2014 · 2 comments
Closed

Apps initial lifecycle and setting screen UI #2083

ErisDS opened this issue Jan 30, 2014 · 2 comments
Assignees
@javorszky
Labels
affects:admin Anything relating to Ghost Admin
Milestone
0.4.2

Comments

@ErisDS
Copy link
Member

ErisDS commented Jan 30, 2014

We have the draft designs in #2065

In order to make the app UI pretty, we need to first setup a settings screen and wire up a little bit of the App lifecycle.

It would be good to start out with:

  1. a new screen in the settings area
  2. a list of app names and versions pulled from the content/apps folder & package.json files (requires Add package.json support for Themes #2081)
  3. the ability to activate and deactivate an app

Something like this:

apps
@javorszky
Copy link
Contributor

hm, dibs? :)

@ghost ghost assigned javorszky Jan 30, 2014
This was referenced Feb 4, 2014
Closed
Closed
Closed
Closed
@javorszky
Copy link
Contributor

A few notes while implementing this, so I don't forget (this is going to be a rolling comment, will keep updating this, unless y'all are happy with me adding comments as I go along):

  • core/server/controllers/admin.js:319 should be reworked. This will cause trouble when apps start implementing their own settings pages. I am adding /settings/apps, and while I could navigate there from the sidebar if landed on user, general or '', when reloading /settings/apps/, I was given a 404, until I added apps to the array. This might be filtered, so individual apps can add their own pages to the allowed sections (or not, need a think).

@javorszky javorszky mentioned this issue Feb 23, 2014
Closed
@ErisDS ErisDS closed this as completed in 667888a Feb 28, 2014
@ErisDS ErisDS modified the milestones: 0.4.2, 0.5 Mar 10, 2014
ErisDS pushed a commit that referenced this issue Mar 14, 2014
@javorszky @ErisDS
Implements Initial lifecycle and App UI start
a1abde6 
Closes #2083

* Added hbs template for apps listing
* Added settings to read the activeApps
* Added viewcontrol to activate / deactivate apps
* Added API handler to store activeApps (by `name` in the `package.json` file)
* On button click it turns the button into "Working" and changes class to `button` (grey one)
* On success, rerenders the pane, adds success notification about apps being saved
* On error, rerenders the pane, adds error notification with error message

Missing:
* tests: couldn't figure out how to add mock apps with mock package.json data
* actually registering, etc, re #2140
* icon from the sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javorszky javorszky

Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Milestone
0.4.2
Development

Successfully merging a pull request may close this issue.

Implements Initial lifecycle and App UI start
2 participants
@ErisDS @javorszky