Abstract Admin Transitions

[rwjblue]

I believe that we can significantly improve our our animations by abstracting them a bit (and avoiding jQuery.animate).

Take a look at this demo of liquid-fire a relatively new ember-cli-addon that makes this trivial with Ember CLI (and I'm sure we could leverage this without moving to Ember CLI first). Liquid Fire uses Velocity.js (which replaces jQuery.animate with a MUCH faster implementation).

IMHO, with a more abstract setup we can handle things (like the bug fixed in #3535) quite a bit better.

[novaugust]

#3237 is our issue to move to ember-cli, thought it might be nice to ref that from here as it's something of a blocker =)

[novaugust]

Is velocity our only option here? I want to bring @PaulAdamDavis in on this and talk about whether we can just do this via classnames. We're seemingly doing so for the new PSM menu that's coming up, right?

[PaulAdamDavis]

My first thought is to keep animations in CSS, but I need to have a play around with Liquid Fire/Velocity before I say much more :)

[novaugust]

That's what I was asking -- if it's CSS-able at all. If it is, I personally am not interested in bringing in a dependency just yet

[rwjblue]

My point is that we should abstract the animations so that they are not done adhoc (implemented individually in each place they are needed). We should move to common components that bring the functionality we want.

How these components actually make the transitions happen (be it via assigning CSS classes or using an external tool) is less of an issue to me.

The beauty of what I am suggesting is that we could completely change the animation layer by changing a handful of these new components and everything "just works".

[novaugust]

Ahhh i'm with you. Hence 'abstract admin transitions' :p maybe i should
reopen my css issue then..
On Sep 6, 2014 3:56 PM, "Robert Jackson" [email protected] wrote:

My point is that we should abstract the animations so that they are not
done adhoc (implemented individually in each place they are needed). We
should move to common components that bring the functionality we want.

How these components actually make the transitions happen (be it via
assigning CSS classes or using an external tool) is less of an issue to me.

The beauty of what I am suggesting is that we could completely change the
animation layer by changing a handful of these new components and
everything "just works".

—
Reply to this email directly or view it on GitHub
#3584 (comment).

[ErisDS]

Is this still an issue post-zelda?

[kevinansfield]

There's nothing that's being animated using jquery now as far as I'm aware. If we run into deeper animation requirements (maybe once settings panes are route-driven?) then liquid-fire is a good solution.

[ErisDS]

Cool, then I'm gonna close it for now.