Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS to replace jquery.animate #3951

Closed
novaugust opened this issue Sep 3, 2014 · 3 comments · Fixed by #4193
Closed

CSS to replace jquery.animate #3951

novaugust opened this issue Sep 3, 2014 · 3 comments · Fixed by #4193
Milestone

Comments

@novaugust
Copy link
Contributor

Description

The Posts content list and Settings menu are two screens that work identically on mobile phones, allowing users to go back and forth between a list/menu and a content screen.

Right now, that going back and forth is powered by jQuery's animate method. It would be beyond wonderful if we could tear that out in favor of just toggling some class.

This would be a part of #3922, and is also relevant to the removal of jQuery from the postscontroller (#3950)

Code Locations

The suspect code is here on the posts controller, and here on the settings views

@novaugust
Copy link
Contributor Author

Sorry @PaulAdamDavis, better to ping you than to assign you =) Would always be wonderful to get some other folks to start writing sass :D

@novaugust novaugust added this to the 0.5.x Backlog milestone Sep 3, 2014
@novaugust
Copy link
Contributor Author

Closing in favor of #3584

@novaugust
Copy link
Contributor Author

Reopening as 3584 is headed in a slightly different direction of abstraction vs straight cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants