Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Sitemap sort order #4611

Closed
JohnONolan opened this issue Dec 9, 2014 · 1 comment · Fixed by #4616
Closed

Bug: Sitemap sort order #4611

JohnONolan opened this issue Dec 9, 2014 · 1 comment · Fixed by #4616
Assignees
@jgable
Labels
bug [triage] something behaving unexpectedly good first issue [triage] Start here if you've never contributed before.
Milestone
Current Backlog

Comments

@JohnONolan
Copy link
Member

Sitemap sort order is currently by last modified date from oldest to newest. It should be exactly the other way around (newest at the top, oldest at the bottom)

Example: http://john.onolan.org/sitemap-posts.xml
@JohnONolan JohnONolan added bug [triage] something behaving unexpectedly good first issue [triage] Start here if you've never contributed before. labels Dec 9, 2014
@JohnONolan JohnONolan added this to the Current Backlog milestone Dec 9, 2014
@jgable
Copy link
Contributor

jgable commented Dec 9, 2014

I can take this one. Should be a quick fix.

jgable added a commit to jgable/Ghost that referenced this issue Dec 9, 2014
@jgable
Sort newest to oldest in sitemap files
ef16c67 
Closes TryGhost#4611

Refactored generateXmlFromNodes to pull the urlElements itself from
sorted values in the lookup

Added some checks to existing unit tests to validate ordering.
@jgable jgable mentioned this issue Dec 9, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgable jgable

Labels
bug [triage] something behaving unexpectedly good first issue [triage] Start here if you've never contributed before.
Projects
None yet
Milestone
Current Backlog
Development

Successfully merging a pull request may close this issue.

Sort newest to oldest in sitemap files jgable/Ghost
2 participants
@JohnONolan @jgable