-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Onboarding - Invite users #5338
Comments
Not 100% sure on whether the multiple invites should be handled client or server side here. It wouldn't be an enormous task to make the API endpoint support multiple creates, but that would make it different to all of the other Also it seems like it might be just creating a nice API endpoint for sending tonnes of spam invites. Handling the multiple invites on the client doesn't make that much of a difference in that regard, but this screen is a one-time accessible thing. I'm tempted to say leave it client side until there's a clear reason to move it. |
I'll pick this up. I'll leave it on the client side for now, and if we have other use cases for a multi-user invite API, we can rethink this. |
Unless someone has a better idea, for now I'm going to use the old error system, for validation errors. That will have to be reconsidered once #5336 gets done. |
That sounds totally sane ;) |
closes TryGhost#5338 - moves skip link to below the submit button - makes the submit button better represent form status - posts notifications based on success/failure of notifications - goes to the invite page after user creation - actually sends invites! functional tests passing for onboarding invitations cleanup for linitng
closes TryGhost#5338 - moves skip link to below the submit button - makes the submit button better represent form status - posts notifications based on success/failure of notifications - goes to the invite page after user creation - actually sends invites! functional tests passing for onboarding invitations cleanup for linitng
This is required as part of the User Onboarding epic: #5315
Screen 3 of the new onboarding flow (see PR #5316) has a text area for listing out email addresses of users you want to invite to your blog. This screen is currently accessible by clicking the '3' icon at the top of the screen - if you submit the form on the 2nd page you will miss this screen!
The emails are split up and basically validated at present, but there is no handling of displaying errors, or actually inviting the users. This can all be handled in the client side, but it may be preferable to update the API to be able to do multiple user invites in one go, and return success/failures for each address individually.
Prior to submission, any validation issues should appear on the form page - using the new red text under the field style shown here to indicate if any of the addresses are invalid emails.
After submission, the user should be logged in and success or failure should be indicated by a normal notification. Clicking on that notification should take you to the team page so you can review the invites.
The text was updated successfully, but these errors were encountered: