Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Flows: On submit / server error message #5635

Closed
ErisDS opened this issue Aug 5, 2015 · 4 comments
Closed

User Flows: On submit / server error message #5635

ErisDS opened this issue Aug 5, 2015 · 4 comments
Assignees
Labels
affects:admin Anything relating to Ghost Admin
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Aug 5, 2015

On the various user flows:

  • login flow
  • password reset flow (form you get to from reset email)
  • user signup (form you get to from invite email)
  • setup

There is a red error message that is shown below the submit button which currently reads 'The password fairy does not approve'

This error is the intended location for any error message which occurs on submit - e.g. if a user submits the form with inline errors uncorrected or if the call goes off to the server and gets a server side message like incorrect password.

The language of the message is an indicator that we wanted to update the messages to be friendlier / more fun, but that can/will be done separately.

The first change that needs to be made here, is to use something like a showFlowError function to display errors that come back from the server in this location, rather than as a big-red-alert.

The second change is to be able to show some sort of message that summarises the errors if there are still inline errors when submit is pressed. This could be a generic, boring 'please complete the form' message to start with.

Ideally, it might pick one from a set of random generic error messages, or be able show something specific to the field that is incorrect. I'm not sure what information is available or what is possible here, so it would be interesting to get some suggestions for what can be done.

The aim is to inject a little bit more personality into the flows & improve the user experience when things aren't going to plan.

@ErisDS ErisDS added this to the Zelda milestone Aug 5, 2015
@ErisDS ErisDS added the affects:admin Anything relating to Ghost Admin label Aug 5, 2015
cobbspur added a commit to cobbspur/Ghost that referenced this issue Aug 10, 2015
refs TryGhost#5635

- fixes format for server errors
- changes signin-api validation errors to be text rather than alerts
cobbspur added a commit to cobbspur/Ghost that referenced this issue Aug 10, 2015
refs TryGhost#5635

- adds enter action to signup fields
- adds validation text errors
@cobbspur
Copy link
Member

Everything here is done other than the random messages. IIRC there is a decision still to be made as to whether or not this is still wanted

@ErisDS
Copy link
Member Author

ErisDS commented Aug 24, 2015

@JohnONolan any further thoughts on this? Shall I close & we can revisit later, or did you want to look at adding randomised or friendlier messages?

@ErisDS
Copy link
Member Author

ErisDS commented Aug 24, 2015

Alternatively can raise a separate issue for that for a later milestone

@ErisDS ErisDS assigned JohnONolan and unassigned cobbspur Aug 25, 2015
@ErisDS ErisDS modified the milestones: Post-Zelda, Zelda Aug 25, 2015
@JohnONolan
Copy link
Member

Can revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

No branches or pull requests

3 participants