Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing HTML emails #3421

Merged
merged 1 commit into from
Jul 29, 2014
Merged

Implementing HTML emails #3421

merged 1 commit into from
Jul 29, 2014

Conversation

morficus
Copy link
Contributor

closes #3082

  • no more in-line HTML strings
  • adding files for "welcome", "reset password", and "invite user" emails
  • added mail.generateContent() to create HTML and plain-text email content
  • refactored methods that trigger emails to send both HTML and plain-text emails

@ErisDS
Copy link
Member

ErisDS commented Jul 28, 2014

Here's what it looks like:

@JohnONolan wanna change anything?

@JohnONolan
Copy link
Member

What's the the inconsistent spaces between paragraphs? Out of interest.

Can I see the HTML for the message content?

@ErisDS
Copy link
Member

ErisDS commented Jul 28, 2014

The HTML is in the commit.

@JohnONolan
Copy link
Member

right - well the gaps are being caused by empty p tags which shouldn't be there

@morficus
Copy link
Contributor Author

looks like there were some non-terminated <p> tags.
will fix, rebase and push in a bit.

@morficus
Copy link
Contributor Author

Here are the updated HTMl emails.
@JohnONolan what do you think?

Your New Ghost Blog

screen shot 2014-07-29 at 12 49 46 am

Rest Password

screen shot 2014-07-29 at 12 48 14 am

{{inviter}} has invited you to join {{blogName}}

screen shot 2014-07-29 at 12 43 36 am

@morficus
Implementing HTML emails
e30e29b 
closes TryGhost#3082
- no more in-line HTML strings
- adding files for "welcome", "reset password", and "invite user" emails
- added mail.generateContent() to create HTML and plain-text email content
- refactored methods that trigger emails to send both HTML and plain-text emails
@JohnONolan
Copy link
Member

🚢

ErisDS added a commit that referenced this pull request Jul 29, 2014
@ErisDS
Merge pull request #3421 from morficus/issue-3082
48a562d 
Implementing HTML emails
@ErisDS ErisDS merged commit 48a562d into TryGhost:master Jul 29, 2014
@morficus morficus deleted the issue-3082 branch August 10, 2014 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invite Email & Signup screen UI changes
3 participants
@morficus @ErisDS @JohnONolan